From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 48F013844062 for ; Sun, 27 Jun 2021 21:40:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 48F013844062 Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-107-e7CSYLHAPRWGOSo3ITxBig-1; Sun, 27 Jun 2021 17:39:59 -0400 X-MC-Unique: e7CSYLHAPRWGOSo3ITxBig-1 Received: by mail-qk1-f199.google.com with SMTP id c3-20020a37b3030000b02903ad0001a2e8so15934887qkf.3 for ; Sun, 27 Jun 2021 14:39:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=qJNnyshNL12VlCUofPi4Cttxye7FrJoImpMVmfMFV8U=; b=fNBUlJ9aqDiUzJdLiVsWzhdUTn7AzDQYPgXXxQ49By1xCvhv6psLWLYY13vXv8erKm 1mbuD34VddcMu78x1FNsoERPhplbT5+smD7P4aPCh5F7YZ1QdEutQqI043XkIK3xsXQe cBtZ+Itg+ixycxSo6BUYKWCp2u/PdxQ/pySD6jaWPA/6i4ss6QJ7cbsvY3n/6f/S7sTC LvrKhCzXVa6VlfrQFChxz7+QjGKvFmk2/emsxtSkUgFvoZDfTeuAQO7oX+0rHqxZJDr0 bvemG/qYnouhAfPodfPmgPbBMiQ+MdxahdFePtJWm+IdSgAU886RGut+GmPYYitOPBlu ZPtg== X-Gm-Message-State: AOAM531HAfgQlUrrbywqLZ7NZZQGayUUOzP/QqbX98ehDQMBOqFowz0v a7WkWmvD9P9ommKx7Nd7ePCjywXePo9RpU4unenmakdfRqgN24ZG6Y+cUFHCS1L0VxAO3+heeTq ygMCLZOvCEkzSlStJXeX/fdeJ9juinfS6T+eTlYwjEOdoUhLYVj2KNMUZGuWMaaG32jLslg== X-Received: by 2002:a37:7046:: with SMTP id l67mr22230937qkc.69.1624829998889; Sun, 27 Jun 2021 14:39:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyJRRQCILHBvVr+i6OHvCtRLl0+Fi3XxPa2wKJ4qDWbA6Vx7957K/WQxome0mMzptmy3XwpeQ== X-Received: by 2002:a37:7046:: with SMTP id l67mr22230926qkc.69.1624829998681; Sun, 27 Jun 2021 14:39:58 -0700 (PDT) Received: from [192.168.1.16] (198-84-214-74.cpe.teksavvy.com. [198.84.214.74]) by smtp.gmail.com with ESMTPSA id j65sm10037401qkd.17.2021.06.27.14.39.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Jun 2021 14:39:58 -0700 (PDT) Subject: Re: [PATCH v3 0/6] Remaining librt to libc moves To: Florian Weimer , libc-alpha@sourceware.org References: From: Carlos O'Donell Organization: Red Hat Message-ID: <31dcea10-592a-bbae-2254-7fb0f071bccd@redhat.com> Date: Sun, 27 Jun 2021 17:39:57 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Jun 2021 21:40:04 -0000 On 6/25/21 7:41 AM, Florian Weimer via Libc-alpha wrote: > This patch reposts the remaining patches, starting at the first > unreviewed patch. I followed Adhemerval's suggestions. > > Tested on i686-linux-gnu and x86_64-linux-gnu. Built with > build-many-glibcs.py. I'm using Reviewed-by to drive a tactical review of this series (patchwork helps me track this, thanks for including the RB's). Patch 1 and 6 need review. I'm reviewing those. With my review that completes a full review of the whole series. Patches 2, 3, 4, and 5 are reviewed by Adhemerval. Overall the series looks good to me, and I know the lack of int to timer_t transition on mips64/n64 caused a hiccup, which involves making a decision on patch 1 to add some kind of change that captures that in a clean way. Patch 1 achieves that goal. > Thanks, > Florian > > Florian Weimer (6): > Linux: Define TIMER_T_WAS_INT_COMPAT in kernel-posix-timers.h > Linux: Move timer_create, timer_delete from librt to libc > Linux: Move timer_getoverrun from librt to libc > Linux: Move timer_gettime, __timer_gettime64 from librt to libc > Linux: Move timer_settime, __timer_settime64 from librt to libc > Linux: Cleanups after librt move > > elf/Makefile | 4 +- > include/time.h | 12 ++- > misc/Makefile | 6 -- > nptl/Makefile | 9 --- > rt/Makefile | 23 ++++-- > rt/Versions | 47 ++++++------ > rt/aio_misc.c | 14 ---- > rt/aio_notify.c | 8 -- > rt/aio_sigqueue.c | 1 - > rt/librt-compat.c | 16 ++-- > sysdeps/generic/aio_misc.h | 43 +++-------- > sysdeps/htl/Makeconfig | 6 ++ > sysdeps/nptl/Makeconfig | 1 + > sysdeps/pthread/Makefile | 14 +--- > sysdeps/unix/sysv/linux/Makefile | 13 ---- > sysdeps/unix/sysv/linux/Versions | 33 +++++---- > sysdeps/unix/sysv/linux/aarch64/libc.abilist | 10 +++ > sysdeps/unix/sysv/linux/aarch64/librt.abilist | 6 +- > sysdeps/unix/sysv/linux/aio_sigqueue.c | 1 - > sysdeps/unix/sysv/linux/alpha/Versions | 5 -- > sysdeps/unix/sysv/linux/alpha/libc.abilist | 15 ++++ > sysdeps/unix/sysv/linux/alpha/librt-compat.c | 2 +- > sysdeps/unix/sysv/linux/alpha/librt.abilist | 12 +-- > sysdeps/unix/sysv/linux/alpha/timer_create.c | 1 - > sysdeps/unix/sysv/linux/alpha/timer_delete.c | 1 - > .../unix/sysv/linux/alpha/timer_getoverr.c | 1 - > sysdeps/unix/sysv/linux/alpha/timer_gettime.c | 1 - > sysdeps/unix/sysv/linux/alpha/timer_settime.c | 1 - > .../sysv/linux/alpha/timer_t_was_int_compat.h | 19 +++++ > sysdeps/unix/sysv/linux/arc/libc.abilist | 10 +++ > sysdeps/unix/sysv/linux/arc/librt.abilist | 6 +- > sysdeps/unix/sysv/linux/arm/be/libc.abilist | 12 +++ > sysdeps/unix/sysv/linux/arm/be/librt.abilist | 8 +- > sysdeps/unix/sysv/linux/arm/le/libc.abilist | 12 +++ > sysdeps/unix/sysv/linux/arm/le/librt.abilist | 8 +- > sysdeps/unix/sysv/linux/csky/libc.abilist | 12 +++ > sysdeps/unix/sysv/linux/csky/librt.abilist | 8 +- > sysdeps/unix/sysv/linux/hppa/libc.abilist | 12 +++ > sysdeps/unix/sysv/linux/hppa/librt.abilist | 8 +- > sysdeps/unix/sysv/linux/i386/libc.abilist | 12 +++ > sysdeps/unix/sysv/linux/i386/librt.abilist | 8 +- > sysdeps/unix/sysv/linux/ia64/Versions | 7 -- > sysdeps/unix/sysv/linux/ia64/libc.abilist | 15 ++++ > sysdeps/unix/sysv/linux/ia64/librt.abilist | 12 +-- > sysdeps/unix/sysv/linux/ia64/timer_create.c | 1 - > sysdeps/unix/sysv/linux/ia64/timer_delete.c | 1 - > sysdeps/unix/sysv/linux/ia64/timer_getoverr.c | 1 - > sysdeps/unix/sysv/linux/ia64/timer_gettime.c | 1 - > sysdeps/unix/sysv/linux/ia64/timer_settime.c | 1 - > .../sysv/linux/ia64/timer_t_was_int_compat.h | 19 +++++ > sysdeps/unix/sysv/linux/kernel-posix-timers.h | 32 +++++--- > sysdeps/unix/sysv/linux/librt-compat.c | 26 +++++++ > .../sysv/linux/m68k/coldfire/libc.abilist | 12 +++ > .../sysv/linux/m68k/coldfire/librt.abilist | 8 +- > .../unix/sysv/linux/m68k/m680x0/libc.abilist | 12 +++ > .../unix/sysv/linux/m68k/m680x0/librt.abilist | 8 +- > .../sysv/linux/microblaze/be/libc.abilist | 12 +++ > .../sysv/linux/microblaze/be/librt.abilist | 8 +- > .../sysv/linux/microblaze/le/libc.abilist | 12 +++ > .../sysv/linux/microblaze/le/librt.abilist | 8 +- > .../sysv/linux/mips/mips32/fpu/libc.abilist | 12 +++ > .../unix/sysv/linux/mips/mips32/librt.abilist | 8 +- > .../sysv/linux/mips/mips32/nofpu/libc.abilist | 12 +++ > .../sysv/linux/mips/mips64/n32/libc.abilist | 12 +++ > .../sysv/linux/mips/mips64/n32/librt.abilist | 8 +- > .../sysv/linux/mips/mips64/n64/libc.abilist | 10 +++ > .../sysv/linux/mips/mips64/n64/librt.abilist | 6 +- > sysdeps/unix/sysv/linux/nios2/libc.abilist | 12 +++ > sysdeps/unix/sysv/linux/nios2/librt.abilist | 8 +- > .../linux/powerpc/powerpc32/fpu/libc.abilist | 12 +++ > .../linux/powerpc/powerpc32/librt.abilist | 8 +- > .../powerpc/powerpc32/nofpu/libc.abilist | 12 +++ > .../sysv/linux/powerpc/powerpc64/Versions | 8 -- > .../linux/powerpc/powerpc64/be/libc.abilist | 15 ++++ > .../linux/powerpc/powerpc64/be/librt.abilist | 12 +-- > .../linux/powerpc/powerpc64/le/libc.abilist | 10 +++ > .../linux/powerpc/powerpc64/le/librt.abilist | 6 +- > .../linux/powerpc/powerpc64/timer_create.c | 1 - > .../linux/powerpc/powerpc64/timer_delete.c | 1 - > .../linux/powerpc/powerpc64/timer_getoverr.c | 1 - > .../linux/powerpc/powerpc64/timer_gettime.c | 1 - > .../linux/powerpc/powerpc64/timer_settime.c | 1 - > .../powerpc64/timer_t_was_int_compat.h | 19 +++++ > .../unix/sysv/linux/riscv/rv32/libc.abilist | 10 +++ > .../unix/sysv/linux/riscv/rv32/librt.abilist | 6 +- > .../unix/sysv/linux/riscv/rv64/libc.abilist | 10 +++ > .../unix/sysv/linux/riscv/rv64/librt.abilist | 6 +- > .../unix/sysv/linux/s390/s390-32/libc.abilist | 12 +++ > .../sysv/linux/s390/s390-32/librt.abilist | 8 +- > sysdeps/unix/sysv/linux/s390/s390-64/Versions | 8 -- > .../unix/sysv/linux/s390/s390-64/libc.abilist | 15 ++++ > .../sysv/linux/s390/s390-64/librt.abilist | 12 +-- > .../sysv/linux/s390/s390-64/timer_create.c | 1 - > .../sysv/linux/s390/s390-64/timer_delete.c | 1 - > .../sysv/linux/s390/s390-64/timer_getoverr.c | 1 - > .../sysv/linux/s390/s390-64/timer_gettime.c | 1 - > .../sysv/linux/s390/s390-64/timer_settime.c | 1 - > .../s390/s390-64/timer_t_was_int_compat.h | 19 +++++ > sysdeps/unix/sysv/linux/sh/be/libc.abilist | 12 +++ > sysdeps/unix/sysv/linux/sh/be/librt.abilist | 8 +- > sysdeps/unix/sysv/linux/sh/le/libc.abilist | 12 +++ > sysdeps/unix/sysv/linux/sh/le/librt.abilist | 8 +- > sysdeps/unix/sysv/linux/sparc/librt-compat.c | 2 +- > .../sysv/linux/sparc/sparc32/libc.abilist | 12 +++ > .../sysv/linux/sparc/sparc32/librt.abilist | 8 +- > .../unix/sysv/linux/sparc/sparc64/Versions | 8 -- > .../sysv/linux/sparc/sparc64/libc.abilist | 15 ++++ > .../sysv/linux/sparc/sparc64/librt.abilist | 12 +-- > .../sysv/linux/sparc/sparc64/timer_create.c | 1 - > .../sysv/linux/sparc/sparc64/timer_delete.c | 1 - > .../sysv/linux/sparc/sparc64/timer_getoverr.c | 1 - > .../sysv/linux/sparc/sparc64/timer_gettime.c | 1 - > .../sysv/linux/sparc/sparc64/timer_settime.c | 1 - > .../sparc/sparc64/timer_t_was_int_compat.h | 19 +++++ > sysdeps/unix/sysv/linux/timer_create.c | 68 +++++++++++++---- > sysdeps/unix/sysv/linux/timer_delete.c | 46 +++++++++--- > sysdeps/unix/sysv/linux/timer_getoverr.c | 32 ++++++-- > sysdeps/unix/sysv/linux/timer_gettime.c | 63 +++++++++++++--- > sysdeps/unix/sysv/linux/timer_routines.c | 10 +-- > sysdeps/unix/sysv/linux/timer_settime.c | 73 +++++++++++++++---- > ...er_getoverr.c => timer_t_was_int_compat.h} | 26 +------ > .../unix/sysv/linux/x86_64/64/libc.abilist | 15 ++++ > .../unix/sysv/linux/x86_64/64/librt.abilist | 12 +-- > .../linux/x86_64/64/timer_t_was_int_compat.h | 19 +++++ > sysdeps/unix/sysv/linux/x86_64/Versions | 8 -- > sysdeps/unix/sysv/linux/x86_64/compat-timer.h | 45 ------------ > sysdeps/unix/sysv/linux/x86_64/timer_create.c | 65 ----------------- > sysdeps/unix/sysv/linux/x86_64/timer_delete.c | 44 ----------- > .../unix/sysv/linux/x86_64/timer_gettime.c | 41 ----------- > .../unix/sysv/linux/x86_64/timer_settime.c | 44 ----------- > .../unix/sysv/linux/x86_64/x32/libc.abilist | 10 +++ > .../unix/sysv/linux/x86_64/x32/librt.abilist | 6 +- > sysvipc/Makefile | 6 -- > time/Makefile | 6 -- > 134 files changed, 924 insertions(+), 779 deletions(-) > delete mode 100644 sysdeps/unix/sysv/linux/alpha/timer_create.c > delete mode 100644 sysdeps/unix/sysv/linux/alpha/timer_delete.c > delete mode 100644 sysdeps/unix/sysv/linux/alpha/timer_getoverr.c > delete mode 100644 sysdeps/unix/sysv/linux/alpha/timer_gettime.c > delete mode 100644 sysdeps/unix/sysv/linux/alpha/timer_settime.c > create mode 100644 sysdeps/unix/sysv/linux/alpha/timer_t_was_int_compat.h > delete mode 100644 sysdeps/unix/sysv/linux/ia64/timer_create.c > delete mode 100644 sysdeps/unix/sysv/linux/ia64/timer_delete.c > delete mode 100644 sysdeps/unix/sysv/linux/ia64/timer_getoverr.c > delete mode 100644 sysdeps/unix/sysv/linux/ia64/timer_gettime.c > delete mode 100644 sysdeps/unix/sysv/linux/ia64/timer_settime.c > create mode 100644 sysdeps/unix/sysv/linux/ia64/timer_t_was_int_compat.h > create mode 100644 sysdeps/unix/sysv/linux/librt-compat.c > delete mode 100644 sysdeps/unix/sysv/linux/powerpc/powerpc64/timer_create.c > delete mode 100644 sysdeps/unix/sysv/linux/powerpc/powerpc64/timer_delete.c > delete mode 100644 sysdeps/unix/sysv/linux/powerpc/powerpc64/timer_getoverr.c > delete mode 100644 sysdeps/unix/sysv/linux/powerpc/powerpc64/timer_gettime.c > delete mode 100644 sysdeps/unix/sysv/linux/powerpc/powerpc64/timer_settime.c > create mode 100644 sysdeps/unix/sysv/linux/powerpc/powerpc64/timer_t_was_int_compat.h > delete mode 100644 sysdeps/unix/sysv/linux/s390/s390-64/timer_create.c > delete mode 100644 sysdeps/unix/sysv/linux/s390/s390-64/timer_delete.c > delete mode 100644 sysdeps/unix/sysv/linux/s390/s390-64/timer_getoverr.c > delete mode 100644 sysdeps/unix/sysv/linux/s390/s390-64/timer_gettime.c > delete mode 100644 sysdeps/unix/sysv/linux/s390/s390-64/timer_settime.c > create mode 100644 sysdeps/unix/sysv/linux/s390/s390-64/timer_t_was_int_compat.h > delete mode 100644 sysdeps/unix/sysv/linux/sparc/sparc64/timer_create.c > delete mode 100644 sysdeps/unix/sysv/linux/sparc/sparc64/timer_delete.c > delete mode 100644 sysdeps/unix/sysv/linux/sparc/sparc64/timer_getoverr.c > delete mode 100644 sysdeps/unix/sysv/linux/sparc/sparc64/timer_gettime.c > delete mode 100644 sysdeps/unix/sysv/linux/sparc/sparc64/timer_settime.c > create mode 100644 sysdeps/unix/sysv/linux/sparc/sparc64/timer_t_was_int_compat.h > rename sysdeps/unix/sysv/linux/{x86_64/timer_getoverr.c => timer_t_was_int_compat.h} (54%) > create mode 100644 sysdeps/unix/sysv/linux/x86_64/64/timer_t_was_int_compat.h > delete mode 100644 sysdeps/unix/sysv/linux/x86_64/compat-timer.h > delete mode 100644 sysdeps/unix/sysv/linux/x86_64/timer_create.c > delete mode 100644 sysdeps/unix/sysv/linux/x86_64/timer_delete.c > delete mode 100644 sysdeps/unix/sysv/linux/x86_64/timer_gettime.c > delete mode 100644 sysdeps/unix/sysv/linux/x86_64/timer_settime.c > -- Cheers, Carlos.