From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 98038 invoked by alias); 12 Sep 2017 14:08:59 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 98029 invoked by uid 89); 12 Sep 2017 14:08:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*M:b831 X-HELO: mail-qk0-f178.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Q6MI0MfYzNon8Zu18iqfN1cM301LLj4u8QiYWtiBgkc=; b=TAb2wi1JEyVTTe06oonMr8/8mTJqfS9NBQH5SKjTVIvXsl8qwtzyOTfeq/2xK1CjAl m/Ckj22HtFaffanbVPEqLGl8zoaXoerOwYdrU6ynDVaDyiTUYSrWmjymxDgLjsjNPxIz uc2xLwU1qS5YZPr5up+rzStJcHx+QNg/4lOiddH9FKmYLlLHPMMXLY+eOPadP+bR2Dmd rE4Sb3DKbV/8Q+EmpH47ODR58L5ifhT3P3TcU9C/vq3rVA8eb1xTuwcW2e4k6j4TnkWJ Yj9hQtHFun4WzW4zIyZ48XE+HdJ0+WtSt2tlm4H/DFbI2l/5+o+2RJsftdsaMQT6z3Jb YmdA== X-Gm-Message-State: AHPjjUhHSYhWe+3Uz9GpzNc2SoNIHxjoPh/M3LfT5EFW7YK1WMuIgKYI +/xHlk3Llicv5lF4BXOygA== X-Google-Smtp-Source: AOwi7QBRV8kQYU9u1i/gnb/36g7xJtoInod/iutGFhZdw52x5oaDZfXht7LJVVOw2iGKoFfb7IXJoA== X-Received: by 10.55.19.136 with SMTP id 8mr19973149qkt.144.1505225334628; Tue, 12 Sep 2017 07:08:54 -0700 (PDT) Subject: Re: [PATCH 7/9] posix: Consolidate glob implementation To: Andreas Schwab Cc: libc-alpha@sourceware.org, Paul Eggert References: <1504643122-14874-1-git-send-email-adhemerval.zanella@linaro.org> <1504643122-14874-8-git-send-email-adhemerval.zanella@linaro.org> From: Adhemerval Zanella Message-ID: <320fff7d-b831-f00a-88ac-95e6367d5a0b@linaro.org> Date: Tue, 12 Sep 2017 14:08:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2017-09/txt/msg00498.txt.bz2 On 12/09/2017 04:35, Andreas Schwab wrote: > On Sep 05 2017, Adhemerval Zanella wrote: > >> * On Linux all implementation now uses a default one with the exception >> of alpha (which requires specific versioning) and s390-32 (which >> different than other 32 bits with support for v2.1 symbol does not >> add a compat one). > > This drops the default glob64 symbol from s390 (the glob64@GLIBC_2.1 > symbol is now hidden). > > Andreas. > That was not what I am seeing from master: $ file libc.so libc.so: ELF 32-bit MSB shared object, IBM S/390, version 1 (GNU/Linux), dynamically linked, interpreter /lib/ld.so.1, for GNU/Linux 3.2.0, not stripped $ s390x-glibc-linux-gnu-objdump -t libc.so | grep glob64 00000000 l df *ABS* 00000000 glob64.os 001221c8 l F .text 0000144e __GI___old_glob64 000b3330 l F .text 0000144e glob64 000b3330 l F .text 0000144e __GI_glob64 000b3330 l F .text 0000144e __glob64 001221c8 l F .text 0000144e __old_glob64 001221c8 g F .text 0000144e glob64@GLIBC_2.1 And checking the build of glob64.os for s390 I do see: [...] extern __typeof (__glob64) glob64 __attribute__ ((alias ("__glob64"))); extern __typeof (glob64) __EI_glob64 __asm__("" "glob64"); extern __typeof (glob64) __EI_glob64 __attribute__((alias ("" "__GI_glob64"))); [...] $ s390x-glibc-linux-gnu-objdump -t posix/glob64.os | grep glob64 posix/glob64.os: file format elf32-s390 000009b0 g F .text 0000144e __glob64 000009b0 g F .text 0000144e .hidden __GI_glob64 000009b0 g F .text 0000144e glob64 And make check/check-abi does not report this issue as well. That kind of issue should be reported by make check-abi, shouldn't it? Are you seeing with on make check?