From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17768 invoked by alias); 28 Oct 2016 11:58:13 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 16640 invoked by uid 89); 28 Oct 2016 11:58:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM autolearn=no version=3.3.2 spammy=claim X-HELO: mail-qk0-f177.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding; bh=Lm9eQnOvcrzyX6F4qXGWFFQnl/sa6YRVDW4uyNkAqp4=; b=OPbvwpzIGO36ykaGbXMFa4/TY+zOAn7IO1//3zTJ9bRkSo56ZWJwYoTJMEkLtgh1gJ Op6ewC3u57h5SU8odq5wCNfO/yIZCCdwkmpRD5Cyfy3R0IHX6kV2trPct+Mkfl26eE59 rI1asRL37/q1x/3FslVFhMFtL/2bIta2lfTFqvri5U2oAne19Fie3/e5MAhSbGtSnEHO aXM5qollR3+GFgeVwhkLYcdHJYM7lwGHCiWPLir/sn+tKnemp7rPR0x4BxemHbpWUMWL yWEyNA6cjzjiBSsoz7g1WrR7Ma2Uxu5RASyjtgguLz09rNxufmD0lj0I5TzOZFVtI2GB d8Mw== X-Gm-Message-State: ABUngveFsDbguMuMAk2tEizzWfCbBFFG9Nz1Dm7hf0TcGmR1UdAf9OROgd9waZb1upKLN9ke X-Received: by 10.55.15.152 with SMTP id 24mr10844568qkp.45.1477655889246; Fri, 28 Oct 2016 04:58:09 -0700 (PDT) Subject: Re: [PATCH] powerpc: Fix TOC stub on powerpc64 clone() To: Tulio Magno Quites Machado Filho , libc-alpha@sourceware.org References: <1477083962-9894-1-git-send-email-tuliom@linux.vnet.ibm.com> From: Carlos O'Donell Message-ID: <32534ecf-02f1-c139-40f4-c18760e88398@redhat.com> Date: Fri, 28 Oct 2016 11:58:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1477083962-9894-1-git-send-email-tuliom@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00514.txt.bz2 On 10/21/2016 05:06 PM, Tulio Magno Quites Machado Filho wrote: > Use a function call to _exit() so that the linker can create a TOC stub > instead of just a branch. > > 2016-10-21 Tulio Magno Quites Machado Filho > > [BZ #20728] > * sysdeps/unix/sysv/linux/powerpc/powerpc64/clone.S: Replace a > branch to _exit() by a function call. > --- > sysdeps/unix/sysv/linux/powerpc/powerpc64/clone.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc64/clone.S b/sysdeps/unix/sysv/linux/powerpc/powerpc64/clone.S > index 7c59b9b..df824f5 100644 > --- a/sysdeps/unix/sysv/linux/powerpc/powerpc64/clone.S > +++ b/sysdeps/unix/sysv/linux/powerpc/powerpc64/clone.S > @@ -97,7 +97,7 @@ L(oldpid): > #ifdef SHARED > b JUMPTARGET(__GI__exit) > #else > - b JUMPTARGET(_exit) > + bl JUMPTARGET(_exit) > /* We won't ever get here but provide a nop so that the linker > will insert a toc adjusting stub if necessary. */ > nop I agree with Adhemerval that this _looks_ good, but you'd have to claim it works _and_ review the final linked code generated by the static linker. -- Cheers, Carlos.