From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41343 invoked by alias); 28 Mar 2018 13:15:54 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 40374 invoked by uid 89); 28 Mar 2018 13:15:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=Hx-languages-length:1182, modifications, elided X-HELO: mail-qt0-f176.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=pv5E07c5AtHJk1A7QwDuiVh7O8BwfGfc16cq3Wd6zeY=; b=rLHTeQGBmkxEVFKhanraJJuknaoAikPfXCt3zCHFsF+bIo7NgblThAnYaZqVC6o+4T QJ29Ws756BksSeKUT2iqeitTKSLnSU+kGYqUc7SsxWxlbM2mdIzL6GOdJxak4n3LNmQf ftRXqrWqr31esyamrrCCuhCMhMH5lbjMolaEEkENRZ9RUPR4dyyAGh83MTnw77kh7mtk luDrHIPs8+FdePNPg/c7PY6idG6r4i3ZcSOHkLiHXcKOMmYQwRL4UhL43e4ZhogDmT1x GsEsBbrWb7qYudzRUqw0la7k/mEQ1SjiKUe/HV7/mJEAUSa4JscTd1WYdmp2/jQSpaag Za1A== X-Gm-Message-State: AElRT7G8KdJ+oqMzg281v1geOyhg2D5AZNj9zdDPNO4rD3cuk6iIxEeK k0i6ve5fSGv6Zip+DlFnabXYVQ== X-Google-Smtp-Source: AIpwx4+F8EsK58uMQtciPHW/bmnOGKHFQWyXjbPc2AbcwVG/7gssoBP1Qjt5OR7XiWftRQ6R/C/mkw== X-Received: by 10.237.33.111 with SMTP id 102mr5269297qtc.234.1522242945211; Wed, 28 Mar 2018 06:15:45 -0700 (PDT) Subject: Re: Questions about failing testcase nptl/test-mutex-printers To: Stefan Liebler , GNU C Library Cc: Martin Galvan , Andi Kleen , Adhemerval Zanella , tuliom@linux.vnet.ibm.com, raji@linux.vnet.ibm.com, Andreas Arnez References: From: Carlos O'Donell Message-ID: <3279564a-c051-1690-3b19-c7686c7753aa@redhat.com> Date: Wed, 28 Mar 2018 13:15:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2018-03/txt/msg00587.txt.bz2 On 03/28/2018 06:58 AM, Stefan Liebler wrote: > Does it make sense to disable lock-elision for the pretty-printer-tests? Yes it does, and that is probably the correct answer in this case. Many of the tests rely on looking at the internal details of the lock, particularly if you're going to pretty-print it, and elision does not allow that to happen because the lock and any modifications are elided. > E.g. with the following patch: > diff --git a/scripts/test_printers_common.py b/scripts/test_printers_common.py > index 73ca525556..d74a8b4d4b 100644 > --- a/scripts/test_printers_common.py > +++ b/scripts/test_printers_common.py > @@ -171,6 +171,9 @@ def init_test(test_bin, printer_files, printer_names): >      # Finally, load the test binary. >      test('file {0}'.format(test_bin)) > > +    # Disable lock elision. > +    test('set environment GLIBC_TUNABLES glibc.elision.enable=0') > + >  def go_to_main(): >      """Executes a gdb 'start' command, which takes us to main.""" Someone would have to confirm on at least one other arch to make sure this works as expected. -- Cheers, Carlos.