From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 27871385C406 for ; Sun, 27 Jun 2021 21:32:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 27871385C406 Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-31-Cetvqg0JO_K6SOBYw4bbug-1; Sun, 27 Jun 2021 17:32:02 -0400 X-MC-Unique: Cetvqg0JO_K6SOBYw4bbug-1 Received: by mail-qv1-f69.google.com with SMTP id q10-20020a056214018ab029027751ec9742so15940403qvr.7 for ; Sun, 27 Jun 2021 14:32:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=IE3b8l0Mq6Q9RIOeIpTFjpwPkgt/WNlmJGzxDyRz/Lk=; b=CvL10YZU6gGJlaZPYgHHNEDRR/Z2Oeip5GwqYrZ3Cj11MYNpw34xnQr4qqcSIyNej4 fgFw8eZT2Ew1bvfx1cdJUuNyR1/H2O/j1mAUbr/CzFSL5uzPxmtFwotvjsmLRYUZoe8m eudlx++nrMmRn24lxA6StcH+VbQh07CUqyyd6YwNM2HR/0lZ2T3p8DxnpNNwumbfJHjO MlEVCAGPRDsiwT6TyFCqJocrM8NVQInE2gBJ9hVcoVqLQPH1kNgWt6XELRjKcS4ly2DU hN8xNNXt0TpeAjTP/xpzLwQHFHROhhd93fw33JQzISRmpvtyCRk5sH3hy4NzI8VIwxpG DVlw== X-Gm-Message-State: AOAM530rfHbNefpVG1HpdBbKXQ6fzBsph2wINRos3FqTTrv7NYR3+FV1 u/YvkF6UrZsyYll8g34t4cIh5XU34kei8o0zHJUZcWgk3+vxO+IBSXXwRyhQ87hiqTzvj29Siux cCslt+LED0rq23/FfM32FNANQwABgg+vkmaIYCSI+H1kX8TEubVosd16tGe7YuDudft03UA== X-Received: by 2002:ac8:40ca:: with SMTP id f10mr19226611qtm.319.1624829521492; Sun, 27 Jun 2021 14:32:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyWErFoa/Ng1fxPFvwHgrNpyTrluEsL0gF3wHcwyrn9amehLjfccnFKz7UW6ByX06dzAqwc4A== X-Received: by 2002:ac8:40ca:: with SMTP id f10mr19226599qtm.319.1624829521303; Sun, 27 Jun 2021 14:32:01 -0700 (PDT) Received: from [192.168.1.16] (198-84-214-74.cpe.teksavvy.com. [198.84.214.74]) by smtp.gmail.com with ESMTPSA id n207sm9450997qka.101.2021.06.27.14.32.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Jun 2021 14:32:00 -0700 (PDT) Subject: Re: [PATCH 1/4] nptl_db: Install libthread_db under a regular implementation name To: Florian Weimer , libc-alpha@sourceware.org References: <33e06caaa6f9da0321f68d47090164b804429f2a.1623312996.git.fweimer@redhat.com> From: Carlos O'Donell Organization: Red Hat Message-ID: <32b5127b-5015-a6d4-246b-d253c884605e@redhat.com> Date: Sun, 27 Jun 2021 17:32:00 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <33e06caaa6f9da0321f68d47090164b804429f2a.1623312996.git.fweimer@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Jun 2021 21:32:05 -0000 On 6/10/21 4:23 AM, Florian Weimer via Libc-alpha wrote: > Currently, the name is always libthread_db-1.0.so. It does not change > with the glibc version, like the other libraries. Correct. > GDB hard-codes libthread_db.so.1 (the soname), so this change does not > affect loading libthread_db. Right. No regressions on x86_64 or i686. Installed files look good. Reviewed-by: Carlos O'Donell Tested-by: Carlos O'Donell > Tested on x86_64-linux-gnu, in an environment where the nptl GDB tests > actually run. > --- > nptl_db/Makefile | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/nptl_db/Makefile b/nptl_db/Makefile > index ea721c1dcf..1f79c018a1 100644 > --- a/nptl_db/Makefile > +++ b/nptl_db/Makefile > @@ -21,8 +21,6 @@ subdir := nptl_db > > include ../Makeconfig > > -nptl_db-version = 1.0 > - > extra-libs = libthread_db > extra-libs-others := $(extra-libs) > > -- Cheers, Carlos.