From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84926 invoked by alias); 14 Aug 2017 13:56:14 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 84897 invoked by uid 89); 14 Aug 2017 13:56:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=inlines X-HELO: homiemail-a91.g.dreamhost.com Subject: Re: [PATCH 0/2] Multiarch hooks for memcpy variants To: Szabolcs Nagy , Wilco Dijkstra , Zack Weinberg Cc: nd@arm.com, "libc-alpha@sourceware.org" References: <18d2fdf8-ca55-1ded-fa66-3509b3bcf8fe@gotplt.org> <598DF02B.8010607@arm.com> <4072a19f-eecb-8cdd-889f-46b4c8b968b4@gotplt.org> <8ce803fd-37d2-d249-9953-1ad60be34518@gotplt.org> <5991A39B.3050202@arm.com> <5991AB12.6070102@arm.com> From: Siddhesh Poyarekar Message-ID: <32bab61d-9c82-ae4f-5580-9c1c556bbfaf@gotplt.org> Date: Mon, 14 Aug 2017 13:56:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <5991AB12.6070102@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-08/txt/msg00518.txt.bz2 On Monday 14 August 2017 07:22 PM, Szabolcs Nagy wrote: > it seems the firefox on my system is compiled with > _FORTIFY_SOURCE, so i checked libxul.so: > > memcpy calls: 2570 (95.5%) > __memcpy_chk calls: 122 (4.5%) > > it seems it's rare that the destination is an array > with known size, so _chk is rarely used, to me it > makes more sense to add static inline __memcpy_chk > to string.h than fiddle with asm and ifunc. See my response to Wilco about static inlines - it requires a full distro rebuild to have any effect and that's a pointless option to have if we have to backport these routines to stable distributions. Siddhesh