* rt: Fix grammar in <sys/cdefs.h>
@ 2020-10-06 22:42 Jonny Grant
2020-10-07 0:02 ` Zack Weinberg
0 siblings, 1 reply; 3+ messages in thread
From: Jonny Grant @ 2020-10-06 22:42 UTC (permalink / raw)
To: libc-alpha
[-- Attachment #1: Type: text/plain, Size: 185 bytes --]
Hello
Two comments have words in not the right order, please find attached a patch to fix it.
ChangeLog:
2020-10-06 Jonny Grant <jg@jguk.org>
* sys/cdefs.h: Fix grammar
[-- Attachment #2: cdefs.h.patch --]
[-- Type: text/x-patch, Size: 877 bytes --]
--- cdefs.h.orig 2020-10-06 21:52:30.345175901 +0100
+++ cdefs.h 2020-10-06 23:36:13.604914244 +0100
@@ -25,7 +25,7 @@
/* The GNU libc does not support any K&R compilers or the traditional mode
of ISO C compilers anymore. Check for some of the combinations not
- anymore supported. */
+ supported anymore. */
#if defined __GNUC__ && !defined __STDC__
# error "You need a ISO C conforming compiler to use the glibc headers"
#endif
@@ -47,7 +47,7 @@
# endif
/* GCC can always grok prototypes. For C++ programs we add throw()
- to help it optimize the function calls. But this works only with
+ to help it optimize the function calls. But this only works with
gcc 2.8.x and egcs. For gcc 3.2 and up we even mark C functions
as non-throwing using a function attribute since programs can use
the -fexceptions options for C code as well. */
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: rt: Fix grammar in <sys/cdefs.h>
2020-10-06 22:42 rt: Fix grammar in <sys/cdefs.h> Jonny Grant
@ 2020-10-07 0:02 ` Zack Weinberg
2020-10-13 20:57 ` Jonny Grant
0 siblings, 1 reply; 3+ messages in thread
From: Zack Weinberg @ 2020-10-07 0:02 UTC (permalink / raw)
To: Jonny Grant; +Cc: GNU C Library
On Tue, Oct 6, 2020 at 6:42 PM Jonny Grant <jg@jguk.org> wrote:
> Two comments have words in not the right order, please find attached a patch to fix it.
This patch looks fine to me.
Note that in StdAmEng as I know it, "this works only with" is not
*wrong*, but "this only works with" is more idiomatic, so, I agree
with both changes.
zw
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: rt: Fix grammar in <sys/cdefs.h>
2020-10-07 0:02 ` Zack Weinberg
@ 2020-10-13 20:57 ` Jonny Grant
0 siblings, 0 replies; 3+ messages in thread
From: Jonny Grant @ 2020-10-13 20:57 UTC (permalink / raw)
To: Zack Weinberg; +Cc: GNU C Library
On 07/10/2020 01:02, Zack Weinberg wrote:
> On Tue, Oct 6, 2020 at 6:42 PM Jonny Grant <jg@jguk.org> wrote:
>> Two comments have words in not the right order, please find attached a patch to fix it.
>
> This patch looks fine to me.
>
> Note that in StdAmEng as I know it, "this works only with" is not
> *wrong*, but "this only works with" is more idiomatic, so, I agree
> with both changes.
>
> zw
>
Hi Zack,
Thank you. May I ask if you can commit the patch?
Jonny
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-13 20:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-06 22:42 rt: Fix grammar in <sys/cdefs.h> Jonny Grant
2020-10-07 0:02 ` Zack Weinberg
2020-10-13 20:57 ` Jonny Grant
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).