From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org
Subject: Re: [PATCH] Update elf tests to use the support test driver.
Date: Thu, 30 Mar 2017 20:52:00 -0000 [thread overview]
Message-ID: <32f6acde-964a-172d-43d7-69514932aaba@linaro.org> (raw)
In-Reply-To: <20170329151407.6476-1-wainersm@linux.vnet.ibm.com>
LGTM with just a comment:
On 29/03/2017 12:14, Wainer dos Santos Moschetta wrote:
> Replaced test-skeleton.c with support/test-driver.c and
> adjusted the tests accordinly.
>
> Checked on x86_64.
>
> diff --git a/elf/next.c b/elf/next.c
> index 6a3670c..3a7dba9 100644
> --- a/elf/next.c
> +++ b/elf/next.c
> @@ -5,7 +5,7 @@ extern int successful_rtld_next_test (void);
> extern void *failing_rtld_next_use (void);
>
>
> -static int
> +int
> do_test (void)
> {
> int result;
> @@ -40,5 +40,4 @@ do_test (void)
> return result;
> }
There is no need to remove the static definition from this function and
for all other every tests which includes the test-driver.c (since it will
end up creating the main entrypoint anyway). I would avoid change it.
next prev parent reply other threads:[~2017-03-30 20:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 15:14 Wainer dos Santos Moschetta
2017-03-30 20:52 ` Adhemerval Zanella [this message]
2017-03-30 20:55 ` Florian Weimer
2017-03-30 21:00 ` Adhemerval Zanella
2017-03-30 21:01 ` Florian Weimer
2017-03-31 20:53 ` Wainer dos Santos Moschetta
2017-04-01 6:58 ` Florian Weimer
2017-04-01 13:58 ` Zack Weinberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32f6acde-964a-172d-43d7-69514932aaba@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).