From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-78344-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 102026 invoked by alias); 30 Mar 2017 20:52:43 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 101416 invoked by uid 89); 30 Mar 2017 20:52:42 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-24.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_LOW,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mail-qt0-f182.google.com
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:subject:to:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding;
        bh=IhXbsm6rSOI4Fb6I/XcTZ3DXAaCbWhQoYBmVqk+yxSg=;
        b=exqZXPfdzIaQyr2HHAbKfMKDVjzj0ixlUF4IbvXcV8cNGtMBthlJRtoNbJosONuvDI
         nSnhXX2RMBsgKb3W+wIeJbmUwu9NhZ2UjEKAe7Y5aaqccUv52v0E0t70+bacdnEpwVEn
         Du46MctARSqn+FDyKM3F7xAtteQAiTxlSyAZU+/mgzwgQizueZtN3H44nQMJpdoBI8rS
         X0QUBrZv4WygOZ1zHpi35ATWU3V8Zstx7w1azysezX3YN150tJVA5wdhEMl8r1BuxijN
         /89TMl+nQVoQpb1aIMM4cuK27iQcdDM1nuRbnvjpalBXOVjcZr5Joz38kDKLoSRqsu8+
         92pA==
X-Gm-Message-State: AFeK/H29ZSQ+K6LWrSN82Gq+yVYp/IHehXw8IZzKb730PNItU1ChKQ55WSN2mZeqMQYb4o5A
X-Received: by 10.200.40.42 with SMTP id 39mr1791712qtq.149.1490907159618;
        Thu, 30 Mar 2017 13:52:39 -0700 (PDT)
Subject: Re: [PATCH] Update elf tests to use the support test driver.
To: libc-alpha@sourceware.org
References: <20170329151407.6476-1-wainersm@linux.vnet.ibm.com>
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Message-ID: <32f6acde-964a-172d-43d7-69514932aaba@linaro.org>
Date: Thu, 30 Mar 2017 20:52:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <20170329151407.6476-1-wainersm@linux.vnet.ibm.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
X-SW-Source: 2017-03/txt/msg00705.txt.bz2

LGTM with just a comment:

On 29/03/2017 12:14, Wainer dos Santos Moschetta wrote:
> Replaced test-skeleton.c with support/test-driver.c and
> adjusted the tests accordinly.
> 
> Checked on x86_64.
> 
> diff --git a/elf/next.c b/elf/next.c
> index 6a3670c..3a7dba9 100644
> --- a/elf/next.c
> +++ b/elf/next.c
> @@ -5,7 +5,7 @@ extern int successful_rtld_next_test (void);
>  extern void *failing_rtld_next_use (void);
>  
>  
> -static int
> +int
>  do_test (void)
>  {
>    int result;
> @@ -40,5 +40,4 @@ do_test (void)
>    return result;
>  }

There is no need to remove the static definition from this function and
for all other every tests which includes the test-driver.c (since it will
end up creating the main entrypoint anyway). I would avoid change it.