From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90726 invoked by alias); 22 Sep 2016 14:42:28 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 90706 invoked by uid 89); 22 Sep 2016 14:42:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Yury, yury X-HELO: mail-qk0-f181.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:references:to:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=VRLhNDamv4nFemMP55nFXvS3qnO0id9NoMTgZ10exPk=; b=MzkPOWkhD8eECYLpznZhO1oAaErbcM3TFIGvElMR/FvIWQCMr2Q17gmYpuSgrOxSFM dRv5Doc6aSsfuHRjcGRUzUeK5aEP3RXnRjazE3kKMjSB7mTPTGaQ7EGUNUdG+Y6vit55 J0hFCD/q7Y5J1vrb/4MGlYucDHMtPqJffIYL20tDGy2XAg5+JhGlLrImDCQjJZX19wzT vI8lsh1OfVb9HwFJq+ecg/W7u4Ga06re9QWepMeQ2IfaPDVIh7lVVo6yCx3BOn7EA5OC lAKFz9pNfBVq6K1JYMzu1HVqIE1u3CY4A+LKTjObpkiIYzs4eFiHmgKO6T1qEUa0gOgL ewBg== X-Gm-Message-State: AA6/9Rmohv791RMRG/pko6EVY+AFhefQh6958QbaO9hfwdq/YdkbZ/pJEPoi+lgauHtXo1kY X-Received: by 10.55.77.7 with SMTP id a7mr2207620qkb.35.1474555335471; Thu, 22 Sep 2016 07:42:15 -0700 (PDT) Subject: Re: [PATCH 4/4] Consolidate Linux truncate implementations References: <1474383714-15187-1-git-send-email-adhemerval.zanella@linaro.org> <1474383714-15187-5-git-send-email-adhemerval.zanella@linaro.org> <20160922142442.GA5914@yury-N73SV> To: libc-alpha@sourceware.org From: Adhemerval Zanella Message-ID: <330498bd-5430-94eb-f033-73236269be13@linaro.org> Date: Thu, 22 Sep 2016 14:42:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160922142442.GA5914@yury-N73SV> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-09/txt/msg00458.txt.bz2 On 22/09/2016 11:24, Yury Norov wrote: >> +/* Truncate PATH to LENGTH bytes. */ >> int >> -truncate64 (const char *path, off64_t length) >> +__truncate64 (const char *path, off64_t length) >> { >> - unsigned int low = length & 0xffffffff; >> - unsigned int high = length >> 32; >> - int result = INLINE_SYSCALL (truncate64, 3, path, >> - __LONG_LONG_PAIR (high, low)); >> - return result; >> + return INLINE_SYSCALL_CALL (truncate64, path, >> + __ALIGNMENT_ARG SYSCALL_LL64 (length)); >> } >> +weak_alias (__truncate64, truncate64) >> + >> +#ifdef __OFF_T_MATCHES_OFF64_T >> +weak_alias (__truncate64, truncate); >> +#endif > > It seems you forgot weak_alias (__truncate64, __truncate); > I do not think it requires to add __truncate alias since glibc currently does have internal calls to truncate.