From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by sourceware.org (Postfix) with ESMTPS id E763E3858D28 for ; Wed, 18 Jan 2023 01:35:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E763E3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-pl1-x62a.google.com with SMTP id k18so11352096pll.5 for ; Tue, 17 Jan 2023 17:35:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=e2Gn34erhnj1pfzgzjXHgufjlRbJLvAAFqHoLfqXlw8=; b=qCWYq+5dk+Fp3JOZVF9o4WBA3+xbzYT3855+3rWz7j2JPSI2D+iRRUDcfW9d/uq629 /c5DUhdkSVvEkK5PXR2/3G+M47O2PiR27hvkirAMLNx6PHrZAGTxjrS3ewiwTu8zxmJG ASaG7WSXhxYBEFa9Y87gpCmAM9bLhhJcD9YcQFjmW7oWOsnuDfJNLxuSqZ0y+R8Xe55N wo5Q4rE4Jqj96d+EFjwPnUH2FIU2haWoNtaqu2WwuvRsu822bV7mdDSAEUL8XxvOWU65 ZlukwrwNGCeFJgiYgIjo/TKEADs6OvkZ6X3Xza/ny1lhnh/8FhkVX4MIMUYddcAEq+en XS6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=e2Gn34erhnj1pfzgzjXHgufjlRbJLvAAFqHoLfqXlw8=; b=KyvPPADFPWPJ7OwJdndDX+77HWzdb0RrHbGqRtLPiWdfkIy5SN6L1DAKrxaK5lDOU5 NHYuKtOfQI+cxPzVIippWZAdebxLWLhFlIeOUposKyAceL/YMfzpT9oaWigisxLzlVXQ wnHnZAL2SWeu4uc8g049YjPNKWzXM/bCi0gayXxTDV2Mr1N5O0bMMbDF1bEMoELw+8VY Luw5NOeHPiQBwv6MgUhTQlrMra+H/H/EVJkwnZlsYcbHYK/HGV04x/kdpFakiBNUxWdL SjLy/sEZQf5FFCdI03RkSLbW4qzPUWkEWPKTo78eEHm1cUs68AzlfRPhFns/gaArYMwg lKbQ== X-Gm-Message-State: AFqh2kpCm3r+41PTMl1IVEVuvgnp4QsdDEuiSsX3h2Zgm88SKK2Vp1V8 8LoFQtz50KQOl+h8T3NwavFW70WWRdO4Qejp X-Google-Smtp-Source: AMrXdXv/lWeNTh4Xdc2jDd1osyA1sHg4IViHjsxGpsRhMJRBr0VcVXdfNTnGv0ob18ItJNhQz681aw== X-Received: by 2002:a17:902:ba88:b0:194:6a18:beb1 with SMTP id k8-20020a170902ba8800b001946a18beb1mr5804832pls.14.1674005741409; Tue, 17 Jan 2023 17:35:41 -0800 (PST) Received: from [192.168.5.146] (rrcs-173-198-77-218.west.biz.rr.com. [173.198.77.218]) by smtp.gmail.com with ESMTPSA id d8-20020a170903230800b00189ac5a2340sm21772558plh.124.2023.01.17.17.35.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Jan 2023 17:35:40 -0800 (PST) Message-ID: <33b5b010-5bec-1418-bc6b-b845b5f66a2c@linaro.org> Date: Tue, 17 Jan 2023 15:35:38 -1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v9 03/22] Add string vectorized find and detection functions Content-Language: en-US To: Adhemerval Zanella , libc-alpha@sourceware.org, Noah Goldstein References: <20230117200014.1299923-1-adhemerval.zanella@linaro.org> <20230117200014.1299923-4-adhemerval.zanella@linaro.org> From: Richard Henderson In-Reply-To: <20230117200014.1299923-4-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/17/23 09:59, Adhemerval Zanella wrote: > +/* Extract the byte at index IDX from word X, with index 0 being the > + least significant byte. */ > +static __always_inline unsigned char > +extractbyte (op_t x, unsigned int idx) Re-reading, "least significant" is misleading at best. Better as "index 0 being the byte at the lowest address". r~