From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69451 invoked by alias); 17 Aug 2018 16:33:36 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 69439 invoked by uid 89); 17 Aug 2018 16:33:35 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*RU:209.85.220.195, Hx-spam-relays-external:209.85.220.195 X-HELO: mail-qk0-f195.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=IBWHmbn/8qBIMx0cjAXrEWf1JkeSPfxXtDeDrjBzyhs=; b=ZaNf+ZeZ9zMtHgGM1/aHDMiJ1jSpTXWFD6DB9ZoeGwKphL74NMwi0ef+sVvBoac9R+ g7seCCWNWbiFCOY43H+cBqSfei7GUcLtU2thkMHZfkucRqjKxsimc2ay0oX4VEa+/Jw+ rE9s5/xSFSNLloW/Y72sUgVWrPClWN1RtC7Ks= Return-Path: Subject: Re: [PATCH] login: Use aliases for most utmpx functions To: libc-alpha@sourceware.org References: <20180817144459.8136E4028A980@oldenburg.str.redhat.com> From: Adhemerval Zanella Openpgp: preference=signencrypt Message-ID: <33ea2a14-0268-7239-dff6-f362d9c1fb0d@linaro.org> Date: Fri, 17 Aug 2018 16:33:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180817144459.8136E4028A980@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-08/txt/msg00400.txt.bz2 On 17/08/2018 11:44, Florian Weimer wrote: > The existing implementations simply called the utmp functions, > with casts if necessary (struct utmpx and struct utmp have the > same layout). > > 2018-08-17 Florian Weimer > > [BZ #23518] > * login/endutxent.c, login/getutxent.c, login/getutxid.c, > login/getutxline.c, login/pututxline.c, login/updwtmpx.c, > login/utmpxname.c, > sysdeps/unix/sysv/linux/s390/s390-32/getutxent.c, > sysdeps/unix/sysv/linux/s390/s390-32/getutxid.c, > sysdeps/unix/sysv/linux/s390/s390-32/getutxline.c, > sysdeps/unix/sysv/linux/s390/s390-32/pututxline.c, > sysdeps/unix/sysv/linux/s390/s390-32/updwtmpx.c: Remove files. > * login/getutent.c (__getutent): Add getutxent, __getutxent > aliases. > * login/getutent_r.c (__setutent): Add setutxent, __setutxent > aliases. > (__pututline): Add pututxline, __pututxline aliases. > (__endutent): Add endutxent, __endutxent aliases. > * login/getutid.c (__getutid): Add getutxid, __getutxid aliases. > * login/getutline.c (__getutline): Add getutxline, __getutxline > aliases. > * login/updwtmpx.c (__updwtmp): Add updwtmx, __updwtmpx aliases. > * login/utmpname.c (__utmpname): Add utmpxname alias. > * sysdeps/gnu/Makefile [$(subdir) == login] (sysdep_routines): > Remove setutxent, getutxent, endutxent, getutxid, getutxline, > pututxline, utmpxname, updwtmpx. > * sysdeps/unix/sysv/linux/s390/s390-32/getutent.c (__getutxent): > Add getutxent alias. > * sysdeps/unix/sysv/linux/s390/s390-32/getutent_r.c > (__setutent): Add setutxent alias. > (__endutent): Add endutxent alias. > (__pututxline): Add pututxline alias. > * sysdeps/unix/sysv/linux/s390/s390-32/getutid.c (__getutxid): Add > getutxid alias. > * sysdeps/unix/sysv/linux/s390/s390-32/getutline.c (__getutxline): > Add getutxline alias. LGTM. I wonder if it is worth to add Static_assert to check for equality of internal offsets from struct utmpx and struct utmp.