From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf2f.google.com (mail-qv1-xf2f.google.com [IPv6:2607:f8b0:4864:20::f2f]) by sourceware.org (Postfix) with ESMTPS id 2A57A3846077 for ; Tue, 11 May 2021 18:13:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2A57A3846077 Received: by mail-qv1-xf2f.google.com with SMTP id u1so10650175qvg.11 for ; Tue, 11 May 2021 11:13:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=y8opAxGASyl+kmxhRWWppJfZZ4rMBz4QJrFt/4+jqoE=; b=kismCd4igH7wDGBLPxyNTUxljF8Yqf3kPjnHsRtHezdMago9AUJ8aIKDR87zW5I0uu RYWM5dc7k1sampMIheWt72NjJjjWN83HD8bCqiudURsLDfVhIJWvsD9a/e8E6rDqUUNW 4eGmm9ziZ62OIjlhjWQQ31BYNtipOh/a+Ymnbm0mxoMtJ3m5GFuqvpRjL1Fs153T9B+c XoVc+Rd39rBXmeXEgh/Owduo3ormnvbYTIGFgUIWG8GoRaaGq71W8K9vqrdbJxM3Uu3D 7kF20cvVr+W2HrJ5kwa28ogm4h0wOk/2PgjdA1AwFXSjc8DRTqEF7JzQjmpv2nYNhLBz fvZw== X-Gm-Message-State: AOAM533/pW9sBPG9BbrbkZrjInILQsGX+AwqxAYWf9ld81au1yECNiWA zuWhTpcg4mBrZWHabieGvTrCZGNmImf8vQ== X-Google-Smtp-Source: ABdhPJxJMMhub3129BqOZZ7LWh0jqLNSzH2hfMNVCT0e7RNVYqE7R+tKt58EIgt0nDzaaNACoZbjlg== X-Received: by 2002:a05:6214:21ce:: with SMTP id d14mr30837560qvh.47.1620756832532; Tue, 11 May 2021 11:13:52 -0700 (PDT) Received: from [192.168.1.4] ([177.194.37.86]) by smtp.gmail.com with ESMTPSA id q28sm14264269qkm.15.2021.05.11.11.13.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 May 2021 11:13:52 -0700 (PDT) Subject: Re: [PATCH 3/3] nptl: Move pthread_cancel into libc To: Florian Weimer Cc: libc-alpha@sourceware.org References: <1c9e0befaa92592c8f6488c1235ebbfe39d0a61c.1620730539.git.fweimer@redhat.com> <76ab35d6-8a65-921a-59ab-be4e0418afba@linaro.org> <87k0o5xjcp.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Message-ID: <341d783d-5432-8cfa-b071-6561902b817d@linaro.org> Date: Tue, 11 May 2021 15:13:50 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <87k0o5xjcp.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 May 2021 18:13:54 -0000 On 11/05/2021 14:37, Florian Weimer wrote: > * Adhemerval Zanella: > >>> diff --git a/nptl/pthreadP.h b/nptl/pthreadP.h >>> index 1692788528..5b844f331a 100644 >>> --- a/nptl/pthreadP.h >>> +++ b/nptl/pthreadP.h >>> @@ -521,7 +521,6 @@ extern pthread_t __pthread_self (void); >>> extern int __pthread_equal (pthread_t thread1, pthread_t thread2); >>> extern int __pthread_detach (pthread_t th); >>> libc_hidden_proto (__pthread_detach) >>> -extern int __pthread_cancel (pthread_t th); >>> extern int __pthread_kill (pthread_t threadid, int signo); >>> extern void __pthread_exit (void *value) __attribute__ ((__noreturn__)); >>> libc_hidden_proto (__pthread_exit) >> >> I am kinda puzzled how the libc_hidden_proto work without the __pthread_cancel >> prototype. > > Sorry, I don't understand the question? Did I leave libc_hidden_def > somewhere by mistake? No, it is from where libc_hidden_proto gets __pthread_cancel definition to use on its internal __typeof.