From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bee.birch.relay.mailchannels.net (bee.birch.relay.mailchannels.net [23.83.209.14]) by sourceware.org (Postfix) with ESMTPS id BB5C93857C64 for ; Fri, 10 Dec 2021 17:35:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BB5C93857C64 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 4D4B3881666; Fri, 10 Dec 2021 17:35:38 +0000 (UTC) Received: from pdx1-sub0-mail-a305.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 127CB8815FA; Fri, 10 Dec 2021 17:35:37 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a305.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.105.57.109 (trex/6.4.3); Fri, 10 Dec 2021 17:35:38 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Grain-Shelf: 68be709010842ad0_1639157737867_1152569138 X-MC-Loop-Signature: 1639157737867:420668685 X-MC-Ingress-Time: 1639157737867 Received: from [192.168.52.116] (unknown [223.185.2.127]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a305.dreamhost.com (Postfix) with ESMTPSA id 4J9dN66cY2z26; Fri, 10 Dec 2021 09:35:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gotplt.org; s=gotplt.org; t=1639157736; bh=2bhQdEN3b0LX6e7PHhuG1G+THfw=; h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding; b=JHsi2iWDbEA76ocToGDHaluBi8YN4OD54JcCLUCPVfB83KbW+tUPI+lgGuYN35NpL ivQvg49EB2AxmREnvKqMeWFmqOBQmnSRfFINbilYzNV0L12PTMyIL+pd9p93m3oZ37 +kSK+NP7n/3BQyU7LnfcO+SB8hrSayCzbG6pU6dU= Message-ID: <342dbc8d-37ae-48e9-0847-97bac6dbc2f7@gotplt.org> Date: Fri, 10 Dec 2021 23:05:31 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH v2] Replace --enable-static-pie with --disable-default-pie Content-Language: en-US To: libc-alpha@sourceware.org Cc: fweimer@redhat.com, Adhemerval Zanella References: <20211207082638.1960585-1-siddhesh@sourceware.org> <20211208063904.1999478-1-siddhesh@sourceware.org> From: Siddhesh Poyarekar In-Reply-To: <20211208063904.1999478-1-siddhesh@sourceware.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3032.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Dec 2021 17:35:47 -0000 On 12/8/21 12:09, Siddhesh Poyarekar via Libc-alpha wrote: > Build glibc programs and tests as PIE by default and enable static-pie > automatically if the architecture and toolchain supports it. > > Also add a new configuration option --disable-default-pie to prevent > building programs as PIE. > > Only the following architectures now have PIE disabled by default > because they do not work at the moment. hppa, ia64, alpha and csky > don't work because the linker is unable to handle a pcrel relocation > generated from PIE objects. The microblaze compiler is currently > failing with an ICE. GNU hurd tries to enable static-pie, which does > not work and hence fails. All these targets have default PIE disabled > at the moment and I have left it to the target maintainers to enable PIE > on their targets. > > build-many-glibcs runs clean for all targets. I also tested x86_64 on > Fedora and Ubuntu, to verify that the default build as well as > --disable-default-pie work as expected with both system toolchains. > > Signed-off-by: Siddhesh Poyarekar > --- > Changes from v1: > - Filed bugs for build-many-glibcs failures and mentioned them. > - Updated comments and documentation based on review comments. Adhemerval, had you reviewed the rest of the changes in v1? If yes then I could push this one since changes are mostly in documentation and comments. Thanks, Siddhesh