From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x334.google.com (mail-ot1-x334.google.com [IPv6:2607:f8b0:4864:20::334]) by sourceware.org (Postfix) with ESMTPS id 27A4E3858D1E for ; Wed, 2 Aug 2023 14:48:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 27A4E3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ot1-x334.google.com with SMTP id 46e09a7af769-6bc8d1878a0so4190593a34.1 for ; Wed, 02 Aug 2023 07:48:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690987709; x=1691592509; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=CVV0PvNP+EC8HiEGC4wR2PezvzZhsiubeOdLo6DaubU=; b=nHX1GP7hom2H3Q3tTsteeDcykKsfVPFtx0lSbrqvFNC/tUaiqJ53C3w+N5IKEQL00M ip6P9uWDG1X9D98jbWcEB0me7UukhM102mziGsSAQtBHMMpoZkIGHDb6tFyj9BG1Ypfj UJXs6msXuS9m/dWeC9Y8jZt9ugG1AS2in4+CZWC38MAptVb2uLDhC2qu+Q5L8hZSHloT D1R/IB+74ZZpZBzgtzMVB/T0cwpsw0lp2gNmj5fzMvXFJqwiCdQklsMCR0kdEnSfdf0a FK5Kp4bJX27yE33CFWVt6AZ9HRMwWq3TXXfECiHEFikSW0V+15xJMFl4kJtjHEg9cAi4 MjCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690987709; x=1691592509; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CVV0PvNP+EC8HiEGC4wR2PezvzZhsiubeOdLo6DaubU=; b=VGegqdNadwZBAwyrIRqrlxMZKSLAvshkAIPtIuaAK0/HU8lOlnxH/1LWEgpD2qpbPk ZpFCzcNNIgzBJCuAe4O6YRXWdwp4JkbXlmW+3SkxC+Q2azcKSJWI/1qAUCaYKjR4jZ6j yVKbZMij5kcRp7rgFNp1oTyJ2zafBMXGGtAzJ2dkYB4LthXGKr+dP49vxLZcxbU+J/tu /rF9VCxybwX2DTB+r4rhRGMOZ3EboTuT/c/Z7SVgGeqePtq33Yjis7K8ytp1xsfSIQbZ CjSqiHD3oTwKr03k0H4CHiQ6QH1YqgvY6MQQ8n9IOiqCSmmXxnlZwCVRf+g2L/ile9XR 5I2Q== X-Gm-Message-State: ABy/qLbKTSJe/pw7iKXFW82KsugSHsdCWpN6VzAwrYICGrCd8Cv1vJRg blHNn5ewVfeXD3rieOrEPM51zse8J6q64aRaaRixtQ== X-Google-Smtp-Source: APBJJlEbAHbJwYjqb9ePrqRFQVV1KfgsvPOQVTaTtwQu+FmSWSxZlPslp0/ZsnrUAJas0XNkGpehqg== X-Received: by 2002:a9d:7e83:0:b0:6b9:ae94:c664 with SMTP id m3-20020a9d7e83000000b006b9ae94c664mr16911801otp.13.1690987709496; Wed, 02 Aug 2023 07:48:29 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c1:9aa9:84f6:53b3:4cd0:ffe6? ([2804:1b3:a7c1:9aa9:84f6:53b3:4cd0:ffe6]) by smtp.gmail.com with ESMTPSA id h16-20020a056830165000b006b871010cb1sm6142216otr.46.2023.08.02.07.48.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Aug 2023 07:48:28 -0700 (PDT) Message-ID: <343b0bb3-c98a-8746-3c63-567247fe6d7e@linaro.org> Date: Wed, 2 Aug 2023 11:48:25 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 2/2] stdlib: Make abort AS-safe (BZ 26275) Content-Language: en-US To: Florian Weimer Cc: Adhemerval Zanella via Libc-alpha , Carlos O'Donell References: <20230731171900.4065501-1-adhemerval.zanella@linaro.org> <20230731171900.4065501-3-adhemerval.zanella@linaro.org> <87h6phyiz5.fsf@oldenburg.str.redhat.com> <87ttthqzaz.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <87ttthqzaz.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 02/08/23 11:44, Florian Weimer wrote: > * Adhemerval Zanella Netto: > >>> I also don't quite understand why we need to take the abort lock in >>> posix_spawn. There isn't any user code that can run in the same address >>> space after the vfork. >> >> My understanding is the potential issues is if caller sets a SIG_IGN >> for SIGABRT, calls abort, and another thread issues posix_spawn just >> after the sigaction returns. With default options (not setting >> POSIX_SPAWN_SETSIGDEF), the process can still see SIG_DFL for SIGABRT, >> where it should be SIG_IGN. > > Right, I missed that. Maybe add a comment? Ack.