From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 86643 invoked by alias); 28 Sep 2016 12:59:33 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 86451 invoked by uid 89); 28 Sep 2016 12:59:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=479,7, 1096, 0x3feb6000, do_sin X-HELO: mail-wm0-f51.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=E5hmXG2FLFflP2qmlLWqUYUr4RwTyt9wc1RMb5L6w4M=; b=DlKpC20OIewA4Y8YDOHUKuQsIJCjNq39e9DukfkPH3m+UJJ6wCd3icu82Po/WcoCyb RP0+07uvgfWwM7VGsJEs8h2Etn3s4k+r7uYbAFmv7jZNhiJla1DEbbvrMO5JRAlg/o0S euF3m4Zic5GHlSL7R9nsgtkLzMzBC2OPixcRiOFNfa/tguHClrLQy9GUYPrcjgN8I+zF pjk+3FLbhIjtm+f9itnJqjhevF0l+WNbqX7VB0rzkNVd6KkqHn3p5JxS5ZzPCQAqZvOi xXbIbW36Tl1QpW8Jvcd/1UHqTZ2TWeEEuCBGXe58WJEPpsa7lxSX/pTDgC3DpjoSyJO7 fBBA== X-Gm-Message-State: AA6/9RmwLNJmKWnmVeOUDllwZILYL3eBP6gxMKJWhlcW9oRGikWliDCcCLlmkLQb7uK0Tg== X-Received: by 10.28.9.210 with SMTP id 201mr8455732wmj.95.1475067569693; Wed, 28 Sep 2016 05:59:29 -0700 (PDT) Subject: Re: [PATCH 4/4] Use copysign instead of ternary for some sin/cos input ranges To: libc-alpha@sourceware.org References: <1474998553-2366-1-git-send-email-siddhesh@sourceware.org> <1474998553-2366-5-git-send-email-siddhesh@sourceware.org> From: Manfred Message-ID: <343e148d-c0ce-c506-a040-a80301856af4@gmail.com> Date: Wed, 28 Sep 2016 12:59:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1474998553-2366-5-git-send-email-siddhesh@sourceware.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2016-09/txt/msg00557.txt.bz2 On 9/27/2016 7:49 PM, Siddhesh Poyarekar wrote: > @@ -479,7 +479,7 @@ __sin (double x) > { > res = do_sin (x, 0, &cor); > retval = (res == res + 1.096 * cor) ? res : slow1 (x); > - retval = m > 0 ? retval : -retval; > + retval = __copysign (retval, x); > } /* else if (k < 0x3feb6000) */ > The ternary uses m, __copysign uses x. It could be correct (I didn't check the full context), but just in case...