From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x332.google.com (mail-ot1-x332.google.com [IPv6:2607:f8b0:4864:20::332]) by sourceware.org (Postfix) with ESMTPS id 4AFC33858C3A for ; Wed, 30 Nov 2022 13:49:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4AFC33858C3A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ot1-x332.google.com with SMTP id db10-20020a0568306b0a00b0066d43e80118so11227945otb.1 for ; Wed, 30 Nov 2022 05:49:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=f2KKDG9+lHFlDut2YwPwqLAZimmB376hPs3pJzv5R/U=; b=T6fXaglUSpu/o+1hMiGdlfogPKs7dVMwskRbxAImyWWVvveEhUmTPi1PGrFM+kUdYd xq7Spnk7jgMP2Dyu6DECZP7XWcmWrOosp0T8N38xfqNTixPZJem/Zw33YcPx+SymxQqa l/9OBssB2+PpiJ/jeoHMB8DQ4TTySTAUXCVq2CGSKtaE2387X+bVntCjOndyHFUutCHF i175V09QT+HVJwTxhfTeJIB3F8C9Z+/itdXKfEjzaGPjHVawsxXHajqxgEhQZqVbVkkj oeKcbdz+6/0pIU9RSIRCcWQ9pTLyK5FT2JwyQq92yzEIU4muv+fciHDforPAl1RlvjjS HBkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=f2KKDG9+lHFlDut2YwPwqLAZimmB376hPs3pJzv5R/U=; b=FQa/4Rqy6ZSN7FaOY/qFKmU9gMbyT5ItQCa5RMecCUTEk5Vv75rrZAN048m8+QInkV XQWxBp1oMcXEUaPfaJL1Ab4PzwWuFpcP6u4z0OUZBL94SEGvL8gM2DAlmidLQTs8HICt l23yXCjBa5MyM2egRZXKWvF3lpnv7WYrvWM/R2hcJ2rcjcLtiZ0bslEEEl+UAZa19L76 t6AlzQ9Us9o9ymlYRJi1QLpCsSJObtwZGv1Q09xvY88bPfk4Q4FTy6BJhVjYybIsnLgs LGIXEyzBePFLbm5W5BDWk0q41VypmJYBzOnRNLU0PwhqkHrTRzUCTreBg0/TUa2n7b+h LaEA== X-Gm-Message-State: ANoB5pmNvijdlPppSUwUb+rk+F9bimJ2b2qhkwA79GeMqO7ObhpI/e2/ ltjX/6AmDXK8kkwQ2liQV+n+PawokiosmQrk X-Google-Smtp-Source: AA0mqf7MGzqFs+3VV1RUAaScSBD97V7ovsc2Tuwt+K6mTQcYytHdRm/K/VvVpYp6LWXEmwCt2Qsdsg== X-Received: by 2002:a05:6830:3081:b0:66e:6892:6ec7 with SMTP id g1-20020a056830308100b0066e68926ec7mr1490827ots.14.1669816168410; Wed, 30 Nov 2022 05:49:28 -0800 (PST) Received: from ?IPV6:2804:1b3:a7c1:f215:4964:69a9:5af9:8453? ([2804:1b3:a7c1:f215:4964:69a9:5af9:8453]) by smtp.gmail.com with ESMTPSA id q23-20020a4adc57000000b0049fda92594asm750205oov.23.2022.11.30.05.49.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Nov 2022 05:49:27 -0800 (PST) Message-ID: <34bc5a63-b4a6-caac-4091-534982646577@linaro.org> Date: Wed, 30 Nov 2022 10:49:25 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] powerpc64: Remove old strncmp optimization Content-Language: en-US To: Paul E Murphy , Rajalakshmi Srinivasaraghavan , libc-alpha@sourceware.org References: <20221129160257.1947346-1-rajis@linux.ibm.com> <8071be27-aebe-6f59-5929-ebf4807046c7@linux.ibm.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <8071be27-aebe-6f59-5929-ebf4807046c7@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 29/11/22 19:37, Paul E Murphy via Libc-alpha wrote: > > > On 11/29/22 10:02 AM, Rajalakshmi Srinivasaraghavan via Libc-alpha wrote: >> This patch removes the power4 strncmp optimization for powerpc64 and uses >> __strncmp_ppc implementation instead.  Currently, both power4 and ppc >> IFUNC variants result in similar performance. > What cpu was used to test performance? I'd be curious if this holds for something like the venerable ppc970. Do we really care, specially because I am not sure how it was evaluated on power4 chip? Otherwise, LGTM.