From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) by sourceware.org (Postfix) with ESMTPS id A05653839C4D for ; Thu, 24 Jun 2021 17:49:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A05653839C4D Received: by mail-qt1-x831.google.com with SMTP id g12so5478342qtb.2 for ; Thu, 24 Jun 2021 10:49:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vKzZWDtojnszK68yjiLoYpz5tVZ22l3GbKBQ9zzpKFs=; b=BPnEV5bKqTo2br6QFfpm6jp+Bp9WGXe3TPGdOfCVCbxDBV0Ff945ZvDLXTUXD4Nl8m 194w412Rwe8RoNuNcbFJ7Mcp6FNNFNjRdgzxcZgVqmbBXrLT9rGntCPkc3rI0mnIbTo1 CYRlNVapG9OJZb3Wd/23j6PURv0PdoeUdz+o52wa2rcDSvc4CopMZU9YT/Uvzk/2n3A6 og0nfd4GpUdPdnUB5ighrG/i7EUxb6shqbz7SWfZX/VzWkqcyTGdg7FeovB6iQTXOImQ gGCeVJ/pi/IXCJWv3vTEO8anuon/PWyisEmVVdOYUwsvY70Wpz6jlQK/2/3+Rw3Z7wLw r77g== X-Gm-Message-State: AOAM53003t4/FNEUQ48StLAbQFw2wBdN7ZUqvVXH40EV40nbqzS1UwsU wBUhJUCGtGAfZY8Rx61bo9Jq/A== X-Google-Smtp-Source: ABdhPJzzzAeZwUJLXSqY4fxEDJ12rFmsnm802YnUV+eY96dgDge/lpcI8JtcbaAvGwQe/15ynpgCdg== X-Received: by 2002:ac8:5508:: with SMTP id j8mr5695101qtq.134.1624556961285; Thu, 24 Jun 2021 10:49:21 -0700 (PDT) Received: from [192.168.1.108] ([177.194.59.218]) by smtp.gmail.com with ESMTPSA id s81sm3050053qka.82.2021.06.24.10.49.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Jun 2021 10:49:20 -0700 (PDT) Subject: Re: [PATCH v2 00/34] Move librt into libc To: libc-alpha@sourceware.org, Florian Weimer References: From: Adhemerval Zanella Message-ID: <3547435c-dc1a-683e-d07c-a39a2f8205f1@linaro.org> Date: Thu, 24 Jun 2021 14:49:18 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jun 2021 17:49:23 -0000 On 17/06/2021 15:56, Florian Weimer via Libc-alpha wrote: > This series contains the adjustments for time64 support. I had to redo > the symbol moves with my local version of the symbol moving scripts to > be sure, but the results look consistent. Ok, I finished reviewing and it does look good. Only two patches I think it will need a bit more work: 1. [29/34] Linux: Define TIMER_T_WAS_INT_COMPAT in kernel-posix-timers.h [1] I think it would be better to move this to its own file, so there is no need to include, undef, define on each arch-specific files. 2. [34/34] Linux: Cleanups after librt move I think you will need to update against master, I have added some more librt linking to add support to timer on some 64-bit time_t tests. [1] https://patchwork.sourceware.org/project/glibc/patch/2f9bd5a3dabea786c943c4a000ac6a1022685e84.1623956058.git.fweimer@redhat.com/ [2] https://patchwork.sourceware.org/project/glibc/patch/df24df16f8483370f9310303f3c54acf010d585.1623956058.git.fweimer@redhat.com/