From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-xc2b.google.com (mail-oo1-xc2b.google.com [IPv6:2607:f8b0:4864:20::c2b]) by sourceware.org (Postfix) with ESMTPS id 563C73858D39 for ; Mon, 6 Mar 2023 18:17:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 563C73858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oo1-xc2b.google.com with SMTP id b10-20020a4aba0a000000b005200c0d4a2aso1662037oop.11 for ; Mon, 06 Mar 2023 10:17:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678126664; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=7n970BwTzmklYFS61BU8nbsEF+oZim35H7YwvWsGM/Q=; b=xAKSJwKVDQ7JaMl2NKnJQCLBJ5TYnZCTCGTAFJgCIq6ZuQnB1Gqgrzfkb0rQqUmTRU PbRXUUF7sXxizkJENV2ZVGtRBkKIll3okc5jRo9kEc2L1e+KYjZK3SgYMRBv3m6xlaNE 6wtep2IiWu2/eUO1FYkvS6Fj4s43e/RhokFFZMTlJakLQyOONLpWSnX8PNRn0VcB2s+g PSzHYJ9s2MMm04d95aNfkJVcIF7UUJScCkPlZCDrRxrasQxRQ6LYDPDARbuvUAEx3G5M RXMkVMKYzrBexggasHkPoSz5oKFtOg4xXv3N1cceAossOxIPKHoco8r6hhgHi3kN7tB9 7O4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678126664; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7n970BwTzmklYFS61BU8nbsEF+oZim35H7YwvWsGM/Q=; b=c7l+AD7yI67DW/ailq9n0nJt3TSYiiGYB/rBsWZxLn6wirjGoYURNm4V8LxGiVGaUu knQKmVr/Uwt8WKUHYkGDWZmEdV5yYzrkM6cgxLUEO5ywsK54CQ00RKAED6ZvhoXsj3KP qxvbjZjVzPGrMnJgviXFJfvsIQyqaMDsZwMAoRLft+6mfMOKEgJNmaImOmDknlgu7CKb cfXwDsEz8w6ry7zLVhTQJY2mDn1TqtkYIyEV63jWLBB/fHmgnAy1GyFef4ZHAN7lJv3F MNAaY7g4Dx2DBMF1TiJU2Rekt63f4BCVubIvMco26naXwi0TIn/d1mlUM1jTvMFKz0iW eXqw== X-Gm-Message-State: AO0yUKXYVUBLc1Y6O8Ak/6IaIzvuAB/dKZRMapwbxWxwQ+vv/nzPE/Rl A6BEZ06cjxBvyl8IaEBGVAaLOA== X-Google-Smtp-Source: AK7set+3JJSgLbVn4fIpod6LDHuKrAbo9LEDmQgLQ11lU0L4+Yes+OZR3mkJIcX0j27Ns+daAgv+lA== X-Received: by 2002:a4a:95c6:0:b0:525:129c:6165 with SMTP id p6-20020a4a95c6000000b00525129c6165mr5636764ooi.6.1678126664565; Mon, 06 Mar 2023 10:17:44 -0800 (PST) Received: from ?IPV6:2804:1b3:a7c3:d849:85a1:d2e8:5a25:72e7? ([2804:1b3:a7c3:d849:85a1:d2e8:5a25:72e7]) by smtp.gmail.com with ESMTPSA id w9-20020a4aa449000000b005200c4b6267sm4089860ool.9.2023.03.06.10.17.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Mar 2023 10:17:43 -0800 (PST) Message-ID: <35682595-a1c6-851c-c85f-7bcc13cb49ce@linaro.org> Date: Mon, 6 Mar 2023 15:17:40 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 2/4] libio: Remove the usage of __libc_IO_vtables Content-Language: en-US From: Adhemerval Zanella Netto To: Andreas Schwab Cc: =?UTF-8?Q?Arsen_Arsenovi=c4=87?= , Florian Weimer , libc-alpha@sourceware.org References: <20221227211145.3765256-1-adhemerval.zanella@linaro.org> <20221227211145.3765256-3-adhemerval.zanella@linaro.org> <87bkl5ncob.fsf@aarsen.me> <89b2e6d3-b5e8-6ee1-12e0-22d4c5ca8e06@linaro.org> <8907cf4b-15de-015d-48c3-9a74ad089d30@linaro.org> Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 06/03/23 14:24, Adhemerval Zanella Netto wrote: > > > On 06/03/23 13:53, Andreas Schwab wrote: >> On Mär 06 2023, Adhemerval Zanella Netto wrote: >> >>> So could be an issue with my patch then? I did not added any new >>> dependency or rule with this patchset. >> >> The new dependency is gen-as-const-headers. >> >> I think it adds a cycle because libio-macros.h depends on >> $(common-objpfx)bits/stdio_lim.h, whereas other gen-as-const-headers >> don't depend on it. > > Right, do we really have to autogenerate stdio_lim.h? It seems that no > target currently requires to the overrides its values. It would be way > simpler if we can assume the sysdeps/posix/Makefile values instead. Alright, I could reproduce it and I am not sure how to fix it. This fix requires libio-macros.sym to correctly setup _IO_file_jumps and _IO_wfile_jumps alias symbol, and the libio/libio-macros.sym requires to know the size ofstruct _IO_jump_t (which in turn uses function pointer that uses FILE *). So libio-macros.sym does require stdio_lim.h in the end. Best solution I can think of is to just remove stdio_lim.h autogeneration, the only real system dependent definition is FILENAME_MAX, obtained from kernel limits.h. I think it should be feasible to just define is a 1024 for hurd and 4096 for Linux (these should not change in near future and change it might incur in some compatibility issues).