From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org
Subject: Re: [PATCH] Fix pretty printer tests for run-built-tests == no
Date: Wed, 28 Dec 2016 22:15:00 -0000 [thread overview]
Message-ID: <357b21f7-cbc2-aa23-934a-ac55de8f74d0@linaro.org> (raw)
In-Reply-To: <1482805594-29119-1-git-send-email-siddhesh@sourceware.org>
LGTM, I have hit this issue and I was about to investigate. Thanks for
checking on it.
On 27/12/2016 00:26, Siddhesh Poyarekar wrote:
> In my change to add configure tests for python I had a brainfart where
> I tried to filter out unsupported tests from tests-printers-programs
> instead of tests-printers to select tests to build. I realize now
> that all of that is completely unnecessary and it would be safe to
> just build the tests as long as we don't try to run it.
>
> This patch reverts that bit of the change. Tested with
> run-built-tests = no in config.make.
>
> * Rules (tests): Add tests-printers-programs to tests to be
> built.
> ---
> Rules | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Rules b/Rules
> index 558924d..3195f59 100644
> --- a/Rules
> +++ b/Rules
> @@ -129,9 +129,9 @@ endif
> others: $(py-const)
>
> ifeq ($(run-built-tests),no)
> -tests: $(addprefix $(objpfx),$(filter-out $(tests-unsupported),$(tests) \
> - $(tests-printers-programs)) \
> - $(test-srcs)) $(tests-special)
> +tests: $(addprefix $(objpfx),$(filter-out $(tests-unsupported),$(tests)) \
> + $(test-srcs)) $(tests-special) \
> + $(tests-printers-programs)
> xtests: tests $(xtests-special)
> else
> tests: $(tests:%=$(objpfx)%.out) $(tests-special) $(tests-printers-out)
>
next prev parent reply other threads:[~2016-12-28 22:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-27 2:26 Siddhesh Poyarekar
2016-12-28 22:15 ` Adhemerval Zanella [this message]
2017-08-20 20:03 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=357b21f7-cbc2-aa23-934a-ac55de8f74d0@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).