From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id DAEB83858D1E for ; Wed, 2 Aug 2023 12:47:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DAEB83858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn Received: from loongson.cn (unknown [111.9.175.10]) by gateway (Coremail) with SMTP id _____8BxIvBMUMpk7PsOAA--.34366S3; Wed, 02 Aug 2023 20:47:08 +0800 (CST) Received: from [10.136.15.11] (unknown [111.9.175.10]) by localhost.localdomain (Coremail) with SMTP id AQAAf8DxPCNKUMpkSrFFAA--.30853S3; Wed, 02 Aug 2023 20:47:07 +0800 (CST) Subject: Re: [PATCH 2/2] Loongarch: Add ifunc support and add different versions of strlen To: Xi Ruoyao , libc-alpha@sourceware.org Cc: adhemerval.zanella@linaro.org, caiyinyu@loongson.cn, xuchenghua@loongson.cn, huangpei@loongson.cn References: <20230801070902.1385953-1-dengjianbo@loongson.cn> <20230801070902.1385953-3-dengjianbo@loongson.cn> From: dengjianbo Message-ID: <365b73ad-5abb-4c7c-b3b0-6648955ded28@loongson.cn> Date: Wed, 2 Aug 2023 20:47:06 +0800 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8DxPCNKUMpkSrFFAA--.30853S3 X-CM-SenderInfo: pghqwyxldqu0o6or00hjvr0hdfq/ X-Coremail-Antispam: 1Uk129KBj93XoW7Zw47ur4DJry3Kw1UJr1fAFc_yoW8XF15pa 9a9w45JFZ3Ww1xtr4vkayfWFn5J3y7K3429Fn0vF1UAr4UAr1F9rs29r92gF15Xw48JrWj vwn3WF1xZF15AacCm3ZEXasCq-sJn29KB7ZKAUJUUUU8529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUU9ab4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1Y6r17M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AK xVW8Jr0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx 1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r106r15McIj6I8E87Iv 67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07 AlzVAYIcxG8wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwCFI7km07C2 67AKxVWUXVWUAwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI 8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWU CwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r 1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsG vfC2KfnxnUUI43ZEXa7IU8j-e5UUUUU== X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00,BODY_8BITS,GIT_PATCH_0,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-08-01 22:44, Xi Ruoyao wrote: > On Tue, 2023-08-01 at 15:09 +0800, dengjianbo wrote: > > /* snip */ > >> diff --git a/sysdeps/loongarch/lp64/multiarch/Makefile >> b/sysdeps/loongarch/lp64/multiarch/Makefile >> new file mode 100644 >> index 0000000000..529a8b6bab >> --- /dev/null >> +++ b/sysdeps/loongarch/lp64/multiarch/Makefile >> @@ -0,0 +1,3 @@ >> +ifeq ($(subdir),string) >> +sysdep_routines += strlen-aligned strlen-lsx strlen-lasx >> +endif > Please check if the assembler supports LSX/LASX, if not you should not > add strlen-lsx and strlen-lasx here. We don't want to disallow building > Glibc for LoongArch with old assembler. > A new configuration variable loongarch_vec_asm has been added in patch v2. when doing the configuration, it will check if the assembler supports LSX/LASX and set the corresponding value. Then we can check it in the makefile, decides if the strlen LASX/LSX code can be compiled. +LIBC_CONFIG_VAR([loongarch_vec_asm], [$libc_cv_loongarch_vec_asm]) +++ b/sysdeps/loongarch/lp64/multiarch/Makefile @@ -0,0 +1,11 @@ +ifeq ($(subdir),string) +sysdep_routines += strlen-aligned \ +       # sysdep_routines + +ifeq ($(loongarch_vec_asm), yes) +sysdep_routines += strlen-lsx \ +       strlen-lasx \ +       # sysdep_routines +endif + +endif For detailed info, please kindly find from: https://sourceware.org/pipermail/libc-alpha/2023-August/150566.html