From: Joseph Myers <joseph@codesourcery.com>
To: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
Cc: Sergio Durigan Junior <sergiodj@sergiodj.net>,
<libc-alpha@sourceware.org>
Subject: Re: [PATCH] sysdeps: Clear O_CREAT|O_ACCMODE when trying again on sem_open
Date: Wed, 1 Nov 2023 13:53:08 +0000 [thread overview]
Message-ID: <36e526a-8bb4-fbaf-2e63-b733692d6b31@codesourcery.com> (raw)
In-Reply-To: <c6ec9c67-5d87-427c-98a2-9671e39e1979@linaro.org>
On Wed, 1 Nov 2023, Adhemerval Zanella Netto wrote:
> Joseph, would adding the following on commit message be enough to
> install this patch:
>
> A regression test for this issue would require a complex and cpu
> time consuming logic, since to trigger the wrong code path is not
> straightforward due the racy condition.
Yes, that seems reasonable as justification for not adding a test case.
(Note: I have not reviewed the substance of the patch.)
The default assumption is that a test case is added for a bug fix (that
isn't just fixing an issue shown by an existing testsuite failure, build
failure, etc.), but this assumption may be overcome in a particular case
by a reason the issue is hard to cover in the testsuite.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2023-11-01 13:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 4:21 Sergio Durigan Junior
2023-08-23 7:40 ` Andreas Schwab
2023-08-23 14:10 ` Sergio Durigan Junior
2023-08-23 14:45 ` Adhemerval Zanella Netto
2023-08-23 19:08 ` Sergio Durigan Junior
2023-08-23 21:53 ` Joseph Myers
2023-08-23 13:46 ` Adhemerval Zanella Netto
2023-08-23 14:16 ` Sergio Durigan Junior
2023-08-23 14:23 ` Sergio Durigan Junior
2023-10-28 20:30 ` Sergio Durigan Junior
2023-11-01 13:27 ` Adhemerval Zanella Netto
2023-11-01 13:53 ` Joseph Myers [this message]
2023-11-01 22:14 ` Sergio Durigan Junior
2023-11-01 22:15 ` [PATCH] sysdeps: sem_open: Clear O_CREAT when semaphore file is expected to exist [BZ #30789] Sergio Durigan Junior
2023-11-03 13:04 ` Adhemerval Zanella Netto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36e526a-8bb4-fbaf-2e63-b733692d6b31@codesourcery.com \
--to=joseph@codesourcery.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=sergiodj@sergiodj.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).