From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 5CEA63858D32 for ; Wed, 1 Nov 2023 13:53:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5CEA63858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5CEA63858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=68.232.141.98 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698846797; cv=none; b=BivwgBN7mWfrMnZPF6D9kC7b331XlFB5WZ0SsuX9HxduGuo0nXsVrrx0WjZc9xt58pHK1CIbDKG0SN8iDjZJq5BhGwrU513GzBqqTMSTObp0X446Nimd45UnEpEAuHx9AKLYangTeSVUVgNUIEhDKOxyZs2mDjSKvj/iUfA3j0w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698846797; c=relaxed/simple; bh=UG1xGy0iyPEkdHXnP+ff6Z7p/ksK72lRbn69OFC8CfU=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=vmyI+/v2csH9ClV1ft4N4zLw7qQcEgp8cNR8K2FimFtyqiUAjfezXvlPzUni38Jel8m9W2DBxhTjeGTnTMAgJ14kZl42R7qUvF+R6TRD6wpBuGaJv5RMAUV1cD5llHcUt1DObXCJ4fpG/g0LmfefqKIsSB45lnJX9HroGnWyLzs= ARC-Authentication-Results: i=1; server2.sourceware.org X-CSE-ConnectionGUID: r6QBO0H8QQC9ZsGjBdUMWQ== X-CSE-MsgGUID: XJem4WQdR5iUzY8gqQlYCw== X-IronPort-AV: E=Sophos;i="6.03,268,1694764800"; d="scan'208";a="24122161" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa2.mentor.iphmx.com with ESMTP; 01 Nov 2023 05:53:12 -0800 IronPort-SDR: NZlSCttLgE3F6ziMuMWfp/P13Ac9C7XbSOZjVr0yBDcSFOXwyhdYrh0SBnWm7dIHk7Aw4iSC03 TuVHfumNuL4607tn7pfApnV1Gg5a1mmaVZcvNfLZzZCVo+VVrb2GQ7II6+KSsk3jX2GDba3jq2 UcUl9q4X/Th7Xj9KUzHNFeW35clqwuHDTOsZhfRuCnDoIMMS++KD7hB3ntz6+Fblkkk635tXJc HQ4lGBrasbG/3I0CbkgXDFYgJmWNIyuCPZfM20trWbRWZujci1d3wxZPi9sGqeSerle6bc36tg 6r8= Date: Wed, 1 Nov 2023 13:53:08 +0000 From: Joseph Myers To: Adhemerval Zanella Netto CC: Sergio Durigan Junior , Subject: Re: [PATCH] sysdeps: Clear O_CREAT|O_ACCMODE when trying again on sem_open In-Reply-To: Message-ID: <36e526a-8bb4-fbaf-2e63-b733692d6b31@codesourcery.com> References: <20230823042129.3955131-1-sergiodj@sergiodj.net> <4755cc77-54d0-00e6-62d5-2a90d0c35af2@linaro.org> <87il6qjxqy.fsf@sergiodj.net> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-3103.6 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 1 Nov 2023, Adhemerval Zanella Netto wrote: > Joseph, would adding the following on commit message be enough to > install this patch: > > A regression test for this issue would require a complex and cpu > time consuming logic, since to trigger the wrong code path is not > straightforward due the racy condition. Yes, that seems reasonable as justification for not adding a test case. (Note: I have not reviewed the substance of the patch.) The default assumption is that a test case is added for a bug fix (that isn't just fixing an issue shown by an existing testsuite failure, build failure, etc.), but this assumption may be overcome in a particular case by a reason the issue is hard to cover in the testsuite. -- Joseph S. Myers joseph@codesourcery.com