From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Paul Zimmermann <Paul.Zimmermann@inria.fr>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v6 2/4] Fix the inaccuracy of j1f (BZ 14470) and y1f (BZ 14472)
Date: Mon, 8 Mar 2021 10:38:32 -0300 [thread overview]
Message-ID: <37440e8d-9ee8-6683-a479-d759fb334eda@linaro.org> (raw)
In-Reply-To: <mwim647uux.fsf@tomate.loria.fr>
On 06/03/2021 01:45, Paul Zimmermann wrote:
> Dear Adhemerval,
>
> thank you again for your review. I will prepare a new version. I have just
> one question:
>
>> This routine is similar to the one at sysdeps/ieee754/flt-32/e_j0f.c,
>> maybe move it to a common place and define it once.
>
> is it ok if I put the common routine, still defined as static double
> reduce_aux(), in a new file flt-32/reduce_aux.c, and I include this
> file in both e_j0f.c and e_j1f.c with #include "reduce_aux.c"?
Usually for short sized functions, you can add it as a inline implementation
and let compiler inline it or not. For large functions I would go for a
separate module and a hidden prototype (so we can control de code size).
next prev parent reply other threads:[~2021-03-08 13:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 8:20 [PATCH v6 1/4] Fix the inaccuracy of j0f and of y0f [BZ #14469 and #14471] Paul Zimmermann
2021-03-01 8:20 ` [PATCH v6 2/4] Fix the inaccuracy of j1f (BZ 14470) and y1f (BZ 14472) Paul Zimmermann
2021-03-05 16:37 ` Adhemerval Zanella
2021-03-06 4:45 ` Paul Zimmermann
2021-03-08 13:38 ` Adhemerval Zanella [this message]
2021-03-01 8:20 ` [PATCH v6 3/4] Added new entries for j0/j1/y0/y1 and regenerate ulps Paul Zimmermann
2021-03-05 16:47 ` Adhemerval Zanella
2021-03-06 3:58 ` Paul Zimmermann
2021-03-01 8:20 ` [PATCH v6 4/4] auto-libm-test-in: added xfail's for ibm128-libgcc (Bessel functions) Paul Zimmermann
2021-03-05 12:36 ` Adhemerval Zanella
2021-03-05 14:04 ` Paul Zimmermann
2021-03-05 13:58 ` [PATCH v6 1/4] Fix the inaccuracy of j0f and of y0f [BZ #14469 and #14471] Adhemerval Zanella
2021-03-05 14:51 ` Paul Zimmermann
2021-03-05 14:58 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37440e8d-9ee8-6683-a479-d759fb334eda@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=Paul.Zimmermann@inria.fr \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).