From: Siddhesh Poyarekar <siddhesh@gotplt.org>
To: Wilco Dijkstra <Wilco.Dijkstra@arm.com>,
"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>
Cc: nd <nd@arm.com>
Subject: Re: [PATCH 6/6] Remove slow paths from sin/cos
Date: Fri, 09 Mar 2018 16:02:00 -0000 [thread overview]
Message-ID: <37a3d699-e7aa-a411-f9bf-54aa1491a154@gotplt.org> (raw)
In-Reply-To: <DB6PR0801MB20536DE50F24E83BB7B6182383DE0@DB6PR0801MB2053.eurprd08.prod.outlook.com>
On Friday 09 March 2018 09:22 PM, Wilco Dijkstra wrote:
> Restructure the sincos implementation - rather than rely on odd partial inlining
> of preprocessed portions from sin and cos, explicitly write out the cases.
The intention of keeping the inlines was to avoid duplicating code
across files. With this change one now must remember to make changes in
both files at all times, increasing the chances of an error. Do you see
any gain from duplicating code?
Siddhesh
next prev parent reply other threads:[~2018-03-09 16:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 15:53 Wilco Dijkstra
2018-03-09 16:02 ` Siddhesh Poyarekar [this message]
2018-03-12 17:31 ` Wilco Dijkstra
2018-03-13 8:46 ` Siddhesh Poyarekar
2018-03-13 15:29 ` Wilco Dijkstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37a3d699-e7aa-a411-f9bf-54aa1491a154@gotplt.org \
--to=siddhesh@gotplt.org \
--cc=Wilco.Dijkstra@arm.com \
--cc=libc-alpha@sourceware.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).