From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129297 invoked by alias); 9 Mar 2018 16:02:36 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 128925 invoked by uid 89); 9 Mar 2018 16:02:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy= X-HELO: homiemail-a82.g.dreamhost.com Subject: Re: [PATCH 6/6] Remove slow paths from sin/cos To: Wilco Dijkstra , "libc-alpha@sourceware.org" Cc: nd References: From: Siddhesh Poyarekar Message-ID: <37a3d699-e7aa-a411-f9bf-54aa1491a154@gotplt.org> Date: Fri, 09 Mar 2018 16:02:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-03/txt/msg00236.txt.bz2 On Friday 09 March 2018 09:22 PM, Wilco Dijkstra wrote: > Restructure the sincos implementation - rather than rely on odd partial inlining > of preprocessed portions from sin and cos, explicitly write out the cases. The intention of keeping the inlines was to avoid duplicating code across files. With this change one now must remember to make changes in both files at all times, increasing the chances of an error. Do you see any gain from duplicating code? Siddhesh