From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 2150E3858D33 for ; Tue, 31 Jan 2023 20:29:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2150E3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675196986; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ffQb+YT18IrCF+4zV89pSELwCk7+jnT4jfLrdyABU6E=; b=ZLEw3olFyxkVkbogEb8b3Aa4XJdYorfiPgwWHETrbt4LJI/tRz4/8a5CiNuZ0IOSzZn4st jSO7uLdtOTRDW3qUj2AtSKWLpQddVOVbLlOfu3XnlTUWx0mOb1uHR8Frm2Jw5vjMHhj4AB M0oxu8xG2E4SIH1YhOfxWhFmUJVHPk8= Received: from mail-il1-f199.google.com (mail-il1-f199.google.com [209.85.166.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-48-k-7EZieZPsO545JnDs_4Ew-1; Tue, 31 Jan 2023 15:29:45 -0500 X-MC-Unique: k-7EZieZPsO545JnDs_4Ew-1 Received: by mail-il1-f199.google.com with SMTP id l13-20020a056e0212ed00b00304c6338d79so10171064iln.21 for ; Tue, 31 Jan 2023 12:29:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ffQb+YT18IrCF+4zV89pSELwCk7+jnT4jfLrdyABU6E=; b=OOaKHBr+ulqCZLv98xNDHmpPJ4CILq5gP8hkzlAM4IL+acntS0U10BUDtcoY2TgqQ4 PIy+YZZDPHkOYOODXqumQuSNIcQNXzRbdwZzxlxYZUzzlmVY/IpqoXLfLuCtyA6Qrxxc Ij2bgAwhAL62Po8gFDvronlgBzsL+oGgA6jWOUMh2TWoHerKARrNFvoqXMBEqiNUmvet CXOf2+aupMVTu9CCktL4RYVmb52FVMeDl+8XR60MLSr5QHToG2Rnv9WP50ADxIIPpxU6 i/+nV8iM7vMuKvqdCDXLF6dARqYxKyP4fD7p0RrehQOPwi7/n9YuyQeBiLEu+RjugABz 5Rug== X-Gm-Message-State: AO0yUKW4i3mr0BMcTMcVGkvDw4t9wjsMxfMjSl39cLSUsraZ6hkE/TEk k03rYsyeeSld04jtqbvlujt6lj+J1a6qYN9ekvMu7fi3YzCHNkyRxUYy+t6ZqZE3mGaK3FYPIsG pM03tkR0psotgkZh5/YD2 X-Received: by 2002:a05:6602:2cd5:b0:71e:24ee:5352 with SMTP id j21-20020a0566022cd500b0071e24ee5352mr6328037iow.17.1675196984703; Tue, 31 Jan 2023 12:29:44 -0800 (PST) X-Google-Smtp-Source: AK7set8SylADxTeDPEGmvNoT04qBMNryluDWU7Fk18A6gyFpNgyDa7UDNWiEMJ5fnPS2n9uEXbP2xA== X-Received: by 2002:a05:6602:2cd5:b0:71e:24ee:5352 with SMTP id j21-20020a0566022cd500b0071e24ee5352mr6328030iow.17.1675196984464; Tue, 31 Jan 2023 12:29:44 -0800 (PST) Received: from [192.168.0.241] (192-0-145-146.cpe.teksavvy.com. [192.0.145.146]) by smtp.gmail.com with ESMTPSA id r7-20020a92d987000000b0030f43cefc4bsm5106550iln.53.2023.01.31.12.29.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Jan 2023 12:29:43 -0800 (PST) Message-ID: <37d639d7-5f52-92c5-e32f-31a83a308e66@redhat.com> Date: Tue, 31 Jan 2023 15:29:42 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] doc: correct _FORTIFY_SOURCE doc in features.h To: Siddhesh Poyarekar , fanquake , libc-alpha@sourceware.org References: <20230131132510.98243-1-fanquake@gmail.com> <65bcd2c4-3f0f-12f3-fc06-c476662e6f51@gotplt.org> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <65bcd2c4-3f0f-12f3-fc06-c476662e6f51@gotplt.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00,BODY_8BITS,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/31/23 09:20, Siddhesh Poyarekar wrote: > Thanks, that looks correct.  Carlos, may I push this before you cut the release? > > Reviewed-by: Siddhesh Poyarekar Yes, comment only fix in headers. OK for 2.37. Please push ASAP. > On 2023-01-31 08:25, fanquake via Libc-alpha wrote: >> --- >>   include/features.h | 3 ++- >>   1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/include/features.h b/include/features.h >> index 7d2c7a4f87..07c73b3e55 100644 >> --- a/include/features.h >> +++ b/include/features.h >> @@ -57,7 +57,8 @@ >>               __STRICT_ANSI__). >>        _FORTIFY_SOURCE    Add security hardening to many library functions. >> -            Set to 1 or 2; 2 performs stricter checks than 1. >> +            Set to 1, 2 or 3; 3 performs stricter checks than 2, which >> +            performs stricter checks than 1. >>        _REENTRANT, _THREAD_SAFE >>               Obsolete; equivalent to _POSIX_C_SOURCE=199506L. > -- Cheers, Carlos.