From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88429 invoked by alias); 25 Jul 2019 13:24:53 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 88143 invoked by uid 89); 25 Jul 2019 13:24:38 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-22.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx0a-001b2d01.pphosted.com Subject: Re: [PATCH] test-container: Install with $(sorted-subdirs) [BZ #24794] To: Tulio Magno Quites Machado Filho , libc-alpha@sourceware.org References: <87k1c7zbw2.fsf@linux.ibm.com> <20190725000323.15612-1-tuliom@linux.ibm.com> From: Stefan Liebler Date: Thu, 25 Jul 2019 13:24:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20190725000323.15612-1-tuliom@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit x-cbid: 19072513-0012-0000-0000-000003361937 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19072513-0013-0000-0000-0000216FB0FC Message-Id: <38158ce5-5f79-7f1b-8bd2-0447ffc4c676@linux.ibm.com> X-SW-Source: 2019-07/txt/msg00576.txt.bz2 Hi Tulio, with this patch, testroot.pristine contains the missing getent / makedb executables and libnss_* libraries. Now nss/tst-nss-files-hosts-long and all other container tests are passing. Thanks, Stefan On 7/25/19 2:03 AM, Tulio Magno Quites Machado Filho wrote: > Commit 35e038c1d2ccb3a75395662f9c4f28d85a61444f started to use an > incomplete list of subdirs based on $(all-subdirs) causing > testroot.pristine to miss files from nss. > > Tested if the list of files in testroot.pristine remains the same. > > 2019-07-24 Tulio Magno Quites Machado Filho > > [BZ #24794] > * Makeconfig (all-subdirs): Improved source comments. > * Makefile (testroot.pristine/install.stamp): Pass > subdirs='$(sorted-subdirs)' to make install. > --- > Makeconfig | 6 +++--- > Makefile | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Makeconfig b/Makeconfig > index 0e386fbc19..fd36c58c04 100644 > --- a/Makeconfig > +++ b/Makeconfig > @@ -1267,9 +1267,9 @@ else > libsupport = $(common-objpfx)support/libsupport.a > endif > > -# These are the subdirectories containing the library source. The order > -# is more or less arbitrary. The sorting step will take care of the > -# dependencies. > +# This is a partial list of subdirectories containing the library source. > +# The order is more or less arbitrary. The sorting step will take care of the > +# dependencies and generate sorted-subdirs dynamically. > all-subdirs = csu assert ctype locale intl catgets math setjmp signal \ > stdlib stdio-common libio malloc string wcsmbs time dirent \ > grp pwd posix io termios resource misc socket sysvipc gmon \ > diff --git a/Makefile b/Makefile > index 9fbf705200..ac1125853b 100644 > --- a/Makefile > +++ b/Makefile > @@ -402,7 +402,7 @@ ifeq ($(run-built-tests),yes) > done > endif > $(MAKE) install DESTDIR=$(objpfx)testroot.pristine \ > - subdirs='$(all-subdirs)' > + subdirs='$(sorted-subdirs)' > touch $(objpfx)testroot.pristine/install.stamp > > tests-special-notdir = $(patsubst $(objpfx)%, %, $(tests-special)) >