From: Siddhesh Poyarekar <siddhesh@gotplt.org>
To: Andreas Schwab <schwab@suse.de>, libc-alpha@sourceware.org
Subject: Re: [PATCH] rtld: properly handle root directory in load path (bug 30435)
Date: Wed, 24 May 2023 22:03:40 -0400 [thread overview]
Message-ID: <383b5d3f-45f7-3aa7-2f2b-6fb314b1a988@gotplt.org> (raw)
In-Reply-To: <mvmy1loibpj.fsf@suse.de>
On 2023-05-16 10:37, Andreas Schwab via Libc-alpha wrote:
> Don't strip the trailing slash when checking for existence of a load path
> element to handle the special case of the root directory.
> ---
> elf/dl-load.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
LGTM.
Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
>
> diff --git a/elf/dl-load.c b/elf/dl-load.c
> index 39c63ff1b3..2aa487b49a 100644
> --- a/elf/dl-load.c
> +++ b/elf/dl-load.c
> @@ -1859,7 +1859,7 @@ open_path (const char *name, size_t namelen, int mode,
> test whether there is any directory at all. */
> struct __stat64_t64 st;
>
> - buf[buflen - namelen - 1] = '\0';
> + buf[buflen - namelen] = '\0';
>
> if (__stat64_time64 (buf, &st) != 0
> || ! S_ISDIR (st.st_mode))
next prev parent reply other threads:[~2023-05-25 2:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 14:37 Andreas Schwab
2023-05-25 2:03 ` Siddhesh Poyarekar [this message]
2023-05-25 12:33 ` Adhemerval Zanella Netto
2023-05-25 12:37 ` Siddhesh Poyarekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=383b5d3f-45f7-3aa7-2f2b-6fb314b1a988@gotplt.org \
--to=siddhesh@gotplt.org \
--cc=libc-alpha@sourceware.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).