From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 573F93857710 for ; Tue, 30 May 2023 11:32:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 573F93857710 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685446359; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NISahQwm9VOgnTKMDXQ7z7WOL+SW1FYoP3Xw/DEk7/s=; b=fGP967tgr65nqxOGC7ZJmCFzr6puPQyfZK514zp7Z0yu3+AGu8ZLCbASr71DuKD7/PdvVf GwrOYCnxNm1Ue+5TVpi2ArckD2/rmk+o17atq58Uy2kR9ISOXbWBPfipXqYxcPndve1Vwh ECXfEKeAFE74hxNFNpJbmiMAEY4Xf6Q= Received: from mail-yw1-f200.google.com (mail-yw1-f200.google.com [209.85.128.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-631-UVb9s1ZnM3KZVh-qzpDrnA-1; Tue, 30 May 2023 07:32:37 -0400 X-MC-Unique: UVb9s1ZnM3KZVh-qzpDrnA-1 Received: by mail-yw1-f200.google.com with SMTP id 00721157ae682-565c380565dso79348327b3.1 for ; Tue, 30 May 2023 04:32:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685446357; x=1688038357; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NISahQwm9VOgnTKMDXQ7z7WOL+SW1FYoP3Xw/DEk7/s=; b=M4TpCLSACa9KGdV1xJsvdVCsrmST0xHJGFV2LD4ccg2OwnIKRJzMC3ZY1XuUfoBJMw nY3sld6pWWGaL2NifQUdhCX6ko6b/LPeghualFPY81aWpldbDGqFmOx06HueGDkZvvyS mX/JVHBaPfww+y0m3hgHyhWqoU+Uw+VfULNE/4iFKJD6iL45X+IC00chigQoITsuUm3i GUXJ1Ebm5pR5hvjVLg1B6yKYgDYR9/3PlM5fDy0uAHfLaZ7gYQlO/gPPLYOOKkf7BomS 9XRKtiZfZlqGWewOnDIIARN3U+/fj/dLCutIc5HYxfew5W8JL9wJ+aBYBTKWF89USl90 Islw== X-Gm-Message-State: AC+VfDyTpPf1NgTrjTxQsT51t+/4NspC3X6gjtSjusR9yAg0gmsSoQlx DWTkgIkbRX7ZW/uzUXIBeOKX7jfXwgXx0Ul/wctowLpSDvXpmO2ygJ8jaWh9nfCi5ka3sea2SMC zSgEJE5qfqiSe13L+AM0s X-Received: by 2002:a81:4f05:0:b0:561:987e:27a with SMTP id d5-20020a814f05000000b00561987e027amr2156180ywb.10.1685446357352; Tue, 30 May 2023 04:32:37 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4tT+CgJiMj2ndjM+txk2QjZXBuRSic5iPwG/S8h/YO/7yr2RB2RoE0KKfdFa8hMVUfzTXHEw== X-Received: by 2002:a81:4f05:0:b0:561:987e:27a with SMTP id d5-20020a814f05000000b00561987e027amr2156166ywb.10.1685446357105; Tue, 30 May 2023 04:32:37 -0700 (PDT) Received: from [192.168.0.241] ([198.48.244.52]) by smtp.gmail.com with ESMTPSA id f126-20020a0ddc84000000b0055a7ff0a5cdsm4358097ywe.27.2023.05.30.04.32.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 May 2023 04:32:36 -0700 (PDT) Message-ID: <38748c18-ce9f-1941-5653-55f9f9d6c529@redhat.com> Date: Tue, 30 May 2023 07:32:35 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH glibc] posix: Add error message for EAI_OVERFLOW To: Dridi Boukelmoune , Arjun Shankar Cc: libc-alpha@sourceware.org References: <20230525124503.152721-1-dridi.boukelmoune@gmail.com> From: Carlos O'Donell Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/29/23 12:48, Dridi Boukelmoune via Libc-alpha wrote: >> It would be nice to have a new test for gai_strerror: whether it >> returns a unique string for each of the errors it should handle. It >> also seems that `gai_strerror (0)` returns "Unknown error". It would >> be nice if it returned "Success" instead. strerror already does the >> same, presumably from sysdeps/gnu/errlist.h. Would you be interested >> in fixing one or both of these up? > > I will have a look at how glibc is tested and give it a try. Thanks! The 'gai_strerror()' function is indirectly tested by getaddrinfo() tests in posix/* To add a test for this you would: - Add a new test in posix/* e.g. posix/tst-gai_strerror.c - Add the test to posix/Makefile 'tests' target (lines 191-320) in the correct alpha sort position. Note: python scripts/sort-makefile-lines.py will sort lines for you. - Use '#include ' infrastructure. e.g. posix/tst-fnmatch7.c Additional notes here: https://sourceware.org/glibc/wiki/Testing/Builds -- Cheers, Carlos.