From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 563A9383FD5D for ; Tue, 6 Dec 2022 17:24:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 563A9383FD5D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670347478; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pW4LPdOXN01r6c5i8rZfUUiPZVrbqMpMbirJzYW+T9Q=; b=g1p9xWixksWyVjddUKhjJe89HdZtGl1FMAmmtlInFwIL9wnCUsNbhvPN94Ca0ttc1NXOef YSrTm1TQbWP2p/Yu+wYeZLheOir+L6HNsisHnVSEMC613jrZYmxdWyXp1s01pbGp3sI3Hq LVjJ/AAbMJll8lfj7jPnRp0a8p8wpjM= Received: from mail-il1-f198.google.com (mail-il1-f198.google.com [209.85.166.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-50-VgNADeUMOZiYn_AXnOd8mg-1; Tue, 06 Dec 2022 12:24:36 -0500 X-MC-Unique: VgNADeUMOZiYn_AXnOd8mg-1 Received: by mail-il1-f198.google.com with SMTP id i14-20020a056e020d8e00b003034b93bd07so8095483ilj.14 for ; Tue, 06 Dec 2022 09:24:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pW4LPdOXN01r6c5i8rZfUUiPZVrbqMpMbirJzYW+T9Q=; b=I+8IgON2h0j+sKwJCTaqmgCzZJFVgHslxamJrQywzsJYc0CWS6Q9w4uLzdK6kSdrrV 98xyWsKuDe6nrlLPAWMd4j1N4ie6BjT5bqVkt7C/BZ0uSL79yVvEtrl7buc+6ZglvFln 6X/ohcQzh9yxqVd3bCJtSEKLRT6rofXNMVzA3ONGWmQcjSKsEOLvx/ig4tMb1OlV7zFA 5ycht3XYxhDZdGDrkehvQ0ZsT0Vsm1TSx4CQKyp+6qkZDZLzYfp7DZV332mn7cVo7kkb 0eRX/25VFNuTQT1yjMzOc9P8tsQVylH34rlEP38n+xVVtIeKI1eMtEpcR5ec3ynCYETU 1Hmw== X-Gm-Message-State: ANoB5pnYeKoUWzWdDJlU9hUDHoK5PrsHD1n6dg8gBS/hrP97F9WTBu7/ ShorCDRf6FVf5U4+8CWLRAB+INIFYV0dcp4kyQX6aeq73mTOVAfXetioMoF2YIdj+6d6w3N+Q/1 WUVd1l/zDMUepaSm7ZLkK X-Received: by 2002:a6b:500a:0:b0:6a1:5d00:cf45 with SMTP id e10-20020a6b500a000000b006a15d00cf45mr32637635iob.16.1670347475745; Tue, 06 Dec 2022 09:24:35 -0800 (PST) X-Google-Smtp-Source: AA0mqf7zP9EnjV/CMAOt1z44RLOfZjnl7tm9bCDG5JJDDGavTO5bAnXge/8+Bti2neY8wQMwic5OLw== X-Received: by 2002:a6b:500a:0:b0:6a1:5d00:cf45 with SMTP id e10-20020a6b500a000000b006a15d00cf45mr32637626iob.16.1670347475542; Tue, 06 Dec 2022 09:24:35 -0800 (PST) Received: from [192.168.0.241] (192-0-145-146.cpe.teksavvy.com. [192.0.145.146]) by smtp.gmail.com with ESMTPSA id h34-20020a022b22000000b0037599d3630dsm6925341jaa.28.2022.12.06.09.24.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Dec 2022 09:24:35 -0800 (PST) Message-ID: <388c1e0b-2ae7-e644-1298-93a73ba1f547@redhat.com> Date: Tue, 6 Dec 2022 12:24:34 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 25/30] Linux: Remove unused generic Makefile To: Adhemerval Zanella , libc-alpha@sourceware.org References: <20221019221433.1082017-1-adhemerval.zanella@linaro.org> <20221019221433.1082017-26-adhemerval.zanella@linaro.org> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <20221019221433.1082017-26-adhemerval.zanella@linaro.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/19/22 18:14, Adhemerval Zanella via Libc-alpha wrote: > Both are already defined on default linux Makefile. Is this true? It is defined in the default syscalls.list and built as a wrapper from that. With your series applied I see things like: (echo '#define SYSCALL_NAME epoll_create'; \ echo '#define SYSCALL_NARGS 1'; \ echo '#define SYSCALL_ULONG_ARG_1 0'; \ echo '#define SYSCALL_ULONG_ARG_2 0'; \ echo '#define SYSCALL_SYMBOL epoll_create'; \ echo '#define SYSCALL_NOERRNO 0'; \ echo '#define SYSCALL_ERRVAL 0'; \ echo '#include '; \ ) | gcc -Wl,--build-id=none -c ... objdump -ldr misc/epoll_create.os misc/epoll_create.os: file format elf64-x86-64 Disassembly of section .text: 0000000000000000 <__GI_epoll_create>: epoll_create(): /mnt/ssd/carlos/src/glibc-work/misc/../sysdeps/unix/syscall-template.S:120 0: b8 d5 00 00 00 mov $0xd5,%eax 5: 0f 05 syscall 7: 48 3d 01 f0 ff ff cmp $0xfffffffffffff001,%rax d: 73 01 jae 10 <__GI_epoll_create+0x10> /mnt/ssd/carlos/src/glibc-work/misc/../sysdeps/unix/syscall-template.S:122 f: c3 ret /mnt/ssd/carlos/src/glibc-work/misc/../sysdeps/unix/syscall-template.S:123 10: 48 8b 0d 00 00 00 00 mov 0x0(%rip),%rcx # 17 <__GI_epoll_create+0x17> 13: R_X86_64_GOTTPOFF __libc_errno-0x4 17: f7 d8 neg %eax 19: 64 89 01 mov %eax,%fs:(%rcx) 1c: 48 83 c8 ff or $0xffffffffffffffff,%rax 20: c3 ret There is no Makefile definition for these so the C versions are going to be unused until the syscalls.list entry is removed? May you please confirm using a final build that we don't still need this? Likewise we should probably cross-check bewteen the makefiles and the syscalls-list to see what is and isn't being built with wrappers. > --- > sysdeps/unix/sysv/linux/generic/Makefile | 3 --- > 1 file changed, 3 deletions(-) > delete mode 100644 sysdeps/unix/sysv/linux/generic/Makefile > > diff --git a/sysdeps/unix/sysv/linux/generic/Makefile b/sysdeps/unix/sysv/linux/generic/Makefile > deleted file mode 100644 > index 7e27e79772..0000000000 > --- a/sysdeps/unix/sysv/linux/generic/Makefile > +++ /dev/null > @@ -1,3 +0,0 @@ > -ifeq ($(subdir),misc) > -sysdep_routines += epoll_create inotify_init > -endif -- Cheers, Carlos.