From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-74161-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 30023 invoked by alias); 28 Oct 2016 12:55:44 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 29968 invoked by uid 89); 28 Oct 2016 12:55:41 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=practically, late
X-HELO: mx1.redhat.com
Subject: Re: [PATCH] Fix -Os related -Werror failures.
To: Joseph Myers <joseph@codesourcery.com>
References: <6eac682f-26fa-6a47-9497-357206266ba1@redhat.com>
 <6be7dce5-bfa7-32c7-5bac-6c3b79776683@redhat.com>
 <alpine.DEB.2.20.1610281248260.32491@digraph.polyomino.org.uk>
Cc: "Carlos O'Donell" <carlos@redhat.com>,
        GNU C Library <libc-alpha@sourceware.org>
From: Florian Weimer <fweimer@redhat.com>
Message-ID: <38a493b5-e73f-1bf8-46f0-4121e547a05d@redhat.com>
Date: Fri, 28 Oct 2016 12:55:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.20.1610281248260.32491@digraph.polyomino.org.uk>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2016-10/txt/msg00521.txt.bz2

On 10/28/2016 02:49 PM, Joseph Myers wrote:
> On Fri, 28 Oct 2016, Florian Weimer wrote:
>
>> Those who want to build with -Os or other special compiler flags should just
>> configure with --disable-werror.  We can't account for every optimization
>> someone might want to disable in their build.
>
> I don't think --disable-werror should be encouraged.

-Wmaybe-uninitialized warnings can be issued very late from the 
optimizers, so this is very much a corner case in terms of usefulness 
for -Werror because it is practically guaranteed to have new false 
positives with unusual architectures, compiler versions, and 
optimization flags.

If the presence of this warning in particular leads people to use 
--disable-werror, maybe we should remove it from the default set of 
warnings which trigger errors.

Florian