* [PATCH] libnsl: Do not install libnsl.so, libnsl.a if NIS is disabled [BZ #22701]
@ 2018-01-11 18:22 Florian Weimer
2018-01-12 3:32 ` Carlos O'Donell
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Florian Weimer @ 2018-01-11 18:22 UTC (permalink / raw)
To: libc-alpha
This also skips building the .o files for libnsl.a.
2018-01-11 Florian Weimer <fweimer@redhat.com>
* nis/Makefile (install-lib-ldscripts, $(inst_libdir)/libnsl.so):
Prevent installation of libnsl.so.
(libnsl-inhibit-o): Do not build (or install) static libraries.
diff --git a/nis/Makefile b/nis/Makefile
index b828c5ec4d..702c31eb63 100644
--- a/nis/Makefile
+++ b/nis/Makefile
@@ -69,7 +69,15 @@ libnss_nis-inhibit-o = $(filter-out .os,$(object-suffixes))
libnss_nisplus-routines := $(addprefix nisplus-,$(databases)) nisplus-parser \
nss-nisplus nisplus-initgroups
libnss_nisplus-inhibit-o = $(filter-out .os,$(object-suffixes))
-endif
+
+else # not $(build-obsolete-nsl)
+# Pretend that libnsl.so is a linker script, so that the symbolic link
+# is not installed.
+install-lib-ldscripts = libnsl.so
+$(inst_libdir)/libnsl.so:
+libnsl-inhibit-o = .o # Build no static libnsl.a.
+
+endif # not $(build-obsolete-nsl)
include ../Rules
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] libnsl: Do not install libnsl.so, libnsl.a if NIS is disabled [BZ #22701]
2018-01-11 18:22 [PATCH] libnsl: Do not install libnsl.so, libnsl.a if NIS is disabled [BZ #22701] Florian Weimer
@ 2018-01-12 3:32 ` Carlos O'Donell
2018-01-12 11:31 ` Andreas Schwab
2018-01-27 1:19 ` [PATCH] Build only shared libnsl objects if NIS is disabled (bug 22701) Andreas Schwab
2 siblings, 0 replies; 8+ messages in thread
From: Carlos O'Donell @ 2018-01-12 3:32 UTC (permalink / raw)
To: Florian Weimer, libc-alpha
On 01/11/2018 10:21 AM, Florian Weimer wrote:
> This also skips building the .o files for libnsl.a.
>
> 2018-01-11 Florian Weimer <fweimer@redhat.com>
>
> * nis/Makefile (install-lib-ldscripts, $(inst_libdir)/libnsl.so):
> Prevent installation of libnsl.so.
> (libnsl-inhibit-o): Do not build (or install) static libraries.
LGTM.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> diff --git a/nis/Makefile b/nis/Makefile
> index b828c5ec4d..702c31eb63 100644
> --- a/nis/Makefile
> +++ b/nis/Makefile
> @@ -69,7 +69,15 @@ libnss_nis-inhibit-o = $(filter-out .os,$(object-suffixes))
> libnss_nisplus-routines := $(addprefix nisplus-,$(databases)) nisplus-parser \
> nss-nisplus nisplus-initgroups
> libnss_nisplus-inhibit-o = $(filter-out .os,$(object-suffixes))
> -endif
> +
> +else # not $(build-obsolete-nsl)
> +# Pretend that libnsl.so is a linker script, so that the symbolic link
> +# is not installed.
> +install-lib-ldscripts = libnsl.so
> +$(inst_libdir)/libnsl.so:
> +libnsl-inhibit-o = .o # Build no static libnsl.a.
> +
> +endif # not $(build-obsolete-nsl)
>
> include ../Rules
>
>
--
Cheers,
Carlos.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] libnsl: Do not install libnsl.so, libnsl.a if NIS is disabled [BZ #22701]
2018-01-11 18:22 [PATCH] libnsl: Do not install libnsl.so, libnsl.a if NIS is disabled [BZ #22701] Florian Weimer
2018-01-12 3:32 ` Carlos O'Donell
@ 2018-01-12 11:31 ` Andreas Schwab
2018-01-12 11:53 ` Florian Weimer
2018-01-27 1:19 ` [PATCH] Build only shared libnsl objects if NIS is disabled (bug 22701) Andreas Schwab
2 siblings, 1 reply; 8+ messages in thread
From: Andreas Schwab @ 2018-01-12 11:31 UTC (permalink / raw)
To: Florian Weimer; +Cc: libc-alpha
Why not just remove libnsl from extra-libs, making the makefile a true
nop?
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] libnsl: Do not install libnsl.so, libnsl.a if NIS is disabled [BZ #22701]
2018-01-12 11:31 ` Andreas Schwab
@ 2018-01-12 11:53 ` Florian Weimer
2018-01-12 16:58 ` Andreas Schwab
0 siblings, 1 reply; 8+ messages in thread
From: Florian Weimer @ 2018-01-12 11:53 UTC (permalink / raw)
To: Andreas Schwab; +Cc: libc-alpha
On 01/12/2018 12:31 PM, Andreas Schwab wrote:
> Why not just remove libnsl from extra-libs, making the makefile a true
> nop?
Wouldn't hat drop the library completely?
We need to install libnsl.so.1. Thorsten's replacement is not
ABI-compatible, so we still need the glibc version.
Thanks,
Florian
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] libnsl: Do not install libnsl.so, libnsl.a if NIS is disabled [BZ #22701]
2018-01-12 11:53 ` Florian Weimer
@ 2018-01-12 16:58 ` Andreas Schwab
0 siblings, 0 replies; 8+ messages in thread
From: Andreas Schwab @ 2018-01-12 16:58 UTC (permalink / raw)
To: Florian Weimer; +Cc: libc-alpha
On Jan 12 2018, Florian Weimer <fweimer@redhat.com> wrote:
> We need to install libnsl.so.1.
Right, I missed that.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] Build only shared libnsl objects if NIS is disabled (bug 22701)
2018-01-11 18:22 [PATCH] libnsl: Do not install libnsl.so, libnsl.a if NIS is disabled [BZ #22701] Florian Weimer
2018-01-12 3:32 ` Carlos O'Donell
2018-01-12 11:31 ` Andreas Schwab
@ 2018-01-27 1:19 ` Andreas Schwab
2018-01-27 1:53 ` Florian Weimer
2 siblings, 1 reply; 8+ messages in thread
From: Andreas Schwab @ 2018-01-27 1:19 UTC (permalink / raw)
To: Florian Weimer; +Cc: libc-alpha
[BZ #22701]
* nis/Makefile (libnsl-inhibit-o) [$(build-obsolete-nsl) != yes]:
Build only shared objects.
diff --git a/nis/Makefile b/nis/Makefile
index 01ec4dc357..e7497f7242 100644
--- a/nis/Makefile
+++ b/nis/Makefile
@@ -74,7 +74,8 @@ else # not $(build-obsolete-nsl)
# is not installed.
install-lib-ldscripts = libnsl.so
$(inst_libdir)/libnsl.so:
-libnsl-inhibit-o = .o # Build no static libnsl.a.
+# Build only shared libnsl.
+libnsl-inhibit-o = $(filter-out .os,$(object-suffixes))
endif # not $(build-obsolete-nsl)
--
2.16.1
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Build only shared libnsl objects if NIS is disabled (bug 22701)
2018-01-27 1:19 ` [PATCH] Build only shared libnsl objects if NIS is disabled (bug 22701) Andreas Schwab
@ 2018-01-27 1:53 ` Florian Weimer
2018-01-27 3:58 ` Andreas Schwab
0 siblings, 1 reply; 8+ messages in thread
From: Florian Weimer @ 2018-01-27 1:53 UTC (permalink / raw)
To: Andreas Schwab; +Cc: libc-alpha
On 01/26/2018 07:05 PM, Andreas Schwab wrote:
> -libnsl-inhibit-o = .o # Build no static libnsl.a.
> +# Build only shared libnsl.
> +libnsl-inhibit-o = $(filter-out .os,$(object-suffixes))
Why is this change needed? Is it about --enable-profile builds?
Thanks,
Florian
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Build only shared libnsl objects if NIS is disabled (bug 22701)
2018-01-27 1:53 ` Florian Weimer
@ 2018-01-27 3:58 ` Andreas Schwab
0 siblings, 0 replies; 8+ messages in thread
From: Andreas Schwab @ 2018-01-27 3:58 UTC (permalink / raw)
To: Florian Weimer; +Cc: libc-alpha
On Jan 26 2018, Florian Weimer <fweimer@redhat.com> wrote:
> On 01/26/2018 07:05 PM, Andreas Schwab wrote:
>> -libnsl-inhibit-o = .o # Build no static libnsl.a.
>> +# Build only shared libnsl.
>> +libnsl-inhibit-o = $(filter-out .os,$(object-suffixes))
>
> Why is this change needed? Is it about --enable-profile builds?
Yes.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-01-26 19:50 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-11 18:22 [PATCH] libnsl: Do not install libnsl.so, libnsl.a if NIS is disabled [BZ #22701] Florian Weimer
2018-01-12 3:32 ` Carlos O'Donell
2018-01-12 11:31 ` Andreas Schwab
2018-01-12 11:53 ` Florian Weimer
2018-01-12 16:58 ` Andreas Schwab
2018-01-27 1:19 ` [PATCH] Build only shared libnsl objects if NIS is disabled (bug 22701) Andreas Schwab
2018-01-27 1:53 ` Florian Weimer
2018-01-27 3:58 ` Andreas Schwab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).