From: Xi Ruoyao <xry111@xry111.site>
To: abushwang <abushwangs@gmail.com>,
libc-alpha@sourceware.org, drepper.fsp@gmail.com
Subject: Re: [PATCH] nptl: pthread_rwlock_rdlock return in low priority
Date: Tue, 07 Mar 2023 16:40:10 +0800 [thread overview]
Message-ID: <38edf460b4dba6f33af637f15a528076b1ce5777.camel@xry111.site> (raw)
In-Reply-To: <20230307035030.437573-1-abushwangs@gmail.com>
On Tue, 2023-03-07 at 11:50 +0800, abushwang via Libc-alpha wrote:
> Signed-off-by: abushwang <abushwangs@gmail.com>
> ---
> nptl/pthread_rwlock_common.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/nptl/pthread_rwlock_common.c b/nptl/pthread_rwlock_common.c
> index 5266a00ed1..35b00fc14f 100644
> --- a/nptl/pthread_rwlock_common.c
> +++ b/nptl/pthread_rwlock_common.c
> @@ -389,6 +389,7 @@ __pthread_rwlock_rdlock_full64 (pthread_rwlock_t *rwlock, clockid_t clockid,
> complexity. */
> if (__glibc_likely ((r & PTHREAD_RWLOCK_WRPHASE) == 0))
> return 0;
> +
I don't think simply adding an empty line can fix anything.
> /* Otherwise, if we were in a write phase (states #6 or #8), we must wait
> for explicit hand-over of the read phase; the only exception is if we
> can start a read phase if there is no primary writer currently. */
> --
> 2.36.1
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
next prev parent reply other threads:[~2023-03-07 8:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 3:50 abushwang
2023-03-07 8:40 ` Xi Ruoyao [this message]
2023-03-07 8:53 ` abush wang
2023-03-07 8:56 ` Florian Weimer
2023-03-07 9:06 ` abush wang
2023-03-07 9:57 ` Xi Ruoyao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38edf460b4dba6f33af637f15a528076b1ce5777.camel@xry111.site \
--to=xry111@xry111.site \
--cc=abushwangs@gmail.com \
--cc=drepper.fsp@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).