From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id DD9A23858C2C for ; Wed, 24 Jan 2024 16:25:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DD9A23858C2C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DD9A23858C2C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706113525; cv=none; b=KjwYCoavG+qNL1JCyTAr7DXYw9PyjxdXAT29gmpnH6p1sgUBGlPzF7H0KRBxvT0INQdJniQlXojNvlSZjdOJiW2V18x6n6IF6/SEGadopF6mCIFIX85l5g8ZoRv1tHxTTjD2FdKj5OUuUX7FCi5RLn+JQLH8DsXR4UCpgHDjL5Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706113525; c=relaxed/simple; bh=48NbR8MPxoURcEXaxRXqt1amaHXqoSJjem6K8vbyuMQ=; h=DKIM-Signature:Message-ID:Date:MIME-Version:From:Subject:To; b=JFdCBf7bSbQBB5ELE9PAfmcAqiWiJ8Al+s0l1SJru9MBm0PlcFuzbE3n5VRtL+mEcj1Qwa2zaijTb59kncwrtXTHDuKf5z8Ee7BpzH5nZlI0Jfcp5Iuybb2cXwqt98nAyEBEHcAZnrg7+1aYofFIz5JnuUBSvQ22FZRzh5tqAlY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706113522; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LDRhDveodxhl9434PXYrz8uyNTp+aCWgQ49RiS8QIMk=; b=UIXd5KKqei7oPKpdp+E1qZ5V/SQph79lgzHD8L2d60OFrB6cBwNqaE1SjzaW+UD/J0wgx+ X4902OlipZzejZh5q9b5X9BT5XOpty14fT3nAALeRiJhFyWpVoNeP6pGJ1bpO2eKJRkq2B pWa73ibtQV8llsekWOugkWT/EKd8Khg= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-665-auiCMkCeMd6rZFJlhSpdnQ-1; Wed, 24 Jan 2024 11:25:21 -0500 X-MC-Unique: auiCMkCeMd6rZFJlhSpdnQ-1 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-783350c4584so1011770985a.1 for ; Wed, 24 Jan 2024 08:25:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706113521; x=1706718321; h=content-transfer-encoding:in-reply-to:organization:content-language :references:to:subject:from:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LDRhDveodxhl9434PXYrz8uyNTp+aCWgQ49RiS8QIMk=; b=czoWw3lu+Uc9Vc5IYqQPIL3IuZdEcaqGeo62aXFZ2Dk3cotq0AYcSF+gNijmiSCCK6 +yYOFVp54mPH5wcsEHSkY55ZWcQqBxHBxQeFdWcDYgNQW5nzHj6FlaW7Xw7b5rRAMJjy MaO4xmh9ZXIYQSC6r/AZVOfY66p/GY3vtUhExoUOhMOVMOqhfZj0j4chNUGXJtyzYD8G ZrNpez8hWJLft/tuF+6Awt9hhIROapmfXpS/MFgF4vvpW4yOGURodpc9A2J7Hc28Nzft M2v97nl0GCDy8TRhMmrxe/XKYrMLY/sMFGcBXa1m/xMk/zfrXfr+rWveEJ5MYYO8CHyz zqhQ== X-Gm-Message-State: AOJu0YzW8US++N9p79/0FqCFRDOkNKUGF7aafWZ6gvX+SC7hU8vc9Blx ztKzt3QSOXUw+HVppWKcIaoxxMO6LBijWF5cKRYVX1lrBIPh0OyrqSwoJqn/PUx+9q0XNvrRlCe jyhhGNNmAVKNsbDqMHsIsOdNG463SXmZ/qwiDoZe7a01NOlEaCpnn+x82lQ== X-Received: by 2002:a05:620a:24c1:b0:783:25d4:621b with SMTP id m1-20020a05620a24c100b0078325d4621bmr11753709qkn.80.1706113520898; Wed, 24 Jan 2024 08:25:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IFGK0rqjTMGGMnW1IC2NpEEvEDt+pwFAivyvGbHNxDdk8+v60wHGC/2p0ds8Sf8jDylXRAlOw== X-Received: by 2002:a05:620a:24c1:b0:783:25d4:621b with SMTP id m1-20020a05620a24c100b0078325d4621bmr11753697qkn.80.1706113520597; Wed, 24 Jan 2024 08:25:20 -0800 (PST) Received: from [192.168.0.241] ([198.48.244.52]) by smtp.gmail.com with ESMTPSA id x11-20020ae9e90b000000b007832575779esm4158867qkf.52.2024.01.24.08.25.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Jan 2024 08:25:19 -0800 (PST) Message-ID: <393f9be7-164e-feb7-9952-f40b46688823@redhat.com> Date: Wed, 24 Jan 2024 11:25:18 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 From: Carlos O'Donell Subject: Re: [PATCH] Manual: fix order of arguments of memalign and aligned_alloc To: "Andreas K. Huettel" , Dennis Brendel , libc-alpha@sourceware.org References: <779c4fcc-5dc9-4bc1-9d68-cbce31a0d8e7@redhat.com> Organization: Red Hat In-Reply-To: <779c4fcc-5dc9-4bc1-9d68-cbce31a0d8e7@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/15/24 03:55, Dennis Brendel wrote: > On the summary page the order of the function arguments was reversed, but it is > in correct order in the other places of the manual. LGTM. Confirmed PDF manual looks correct. Andreas, May I please push the manual change? This looks good to me and would correct the API descriptions. Reviewed-by: Carlos O'Donell > BZ #27547 > --- > manual/memory.texi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/manual/memory.texi b/manual/memory.texi > index 258fdbd3a0..78b657627f 100644 > --- a/manual/memory.texi > +++ b/manual/memory.texi > @@ -1502,7 +1502,7 @@ Space}. > Allocate a block of @var{size} bytes, starting on a page boundary. > @xref{Aligned Memory Blocks}. > > -@item void *aligned_alloc (size_t @var{size}, size_t @var{alignment}) > +@item void *aligned_alloc (size_t @var{alignment}, size_t @var{size}) OK. This is correct, verified by checking the ISO C standard. > Allocate a block of @var{size} bytes, starting on an address that is a > multiple of @var{alignment}. @xref{Aligned Memory Blocks}. > > @@ -1510,7 +1510,7 @@ multiple of @var{alignment}. @xref{Aligned Memory Blocks}. > Allocate a block of @var{size} bytes, starting on an address that is a > multiple of @var{alignment}. @xref{Aligned Memory Blocks}. > > -@item void *memalign (size_t @var{size}, size_t @var{boundary}) > +@item void *memalign (size_t @var{boundary}, size_t @var{size}) OK. This is correct, verified against deployed malloc.h and BSD memalign(). > Allocate a block of @var{size} bytes, starting on an address that is a > multiple of @var{boundary}. @xref{Aligned Memory Blocks}. > -- Cheers, Carlos.