From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by sourceware.org (Postfix) with ESMTPS id 45005385841C for ; Mon, 31 Jul 2023 14:40:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 45005385841C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=owlfolio.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=owlfolio.org Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id D344F5C01A3 for ; Mon, 31 Jul 2023 10:40:42 -0400 (EDT) Received: from imap45 ([10.202.2.95]) by compute1.internal (MEProxy); Mon, 31 Jul 2023 10:40:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=owlfolio.org; h= cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1690814442; x=1690900842; bh=o9 NamTnvy/2lB5hRcAn8gXqYMKmhyhwbW6wHPv/Iz+A=; b=k+dwQwxKZC3BOuMXHQ hzMX+HKv/BNnxak4MK07Ys4UKkQTrvozINivhYJPkjYUjBT4HpzE8wJnAoXbYBca U5+JO9Z1iNWgUw/qLY1cvtWir+0SNMR2wDex0Iyx6xxAPHzecMElBQpRmsFD6Qzr LvVQHBwNmZGtL19YLqntFUqRh4ckF6uJLdWJcqb4kHvFA5NB4zktnSBjm3cekNXu OeDQnzTEVFvpfD5I0KU4nkJOIsKsaCXoQXQJhYVNQH9YeABAR4kBHaFHPxDTD+Sq WZ2nZXVwsSv8Oou3h5qo02qPQ3wG0FOjV5w6nuWXEN5rOgT2gzknDh9IpenJTpaG yh8A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1690814442; x=1690900842; bh=o9NamTnvy/2lB 5hRcAn8gXqYMKmhyhwbW6wHPv/Iz+A=; b=wkC0inAuhe6EsGx43rvhDjnJCt2je AHErUE0+atFCrBsj8E/7iu8w1Qu+wid9HGdU53F8GlW8qYrbb2k3WFtRtCjkJldA Nx3bW29qK85ucDhKq35kaJXmRaUasaNn14nYY1FnffR6KK68UNVmegFwNkS/P0kn cibKfEKA3czx00+W/LgvV+y7TfgpIc8n0ZylWDVlIVbQM+Kg1ChxkK6xliYBo5Hh ggLUq9NUYYPezBqYps5VSrc8Dj7zonzCPZsnBv2nZyJlQYVbjFtYnOEICmBDcYQs 3YpZEkuzVpSDR7VjhGd69XO2UNFJJbWlgV2L3bmLX3yAj3h8MBkWRdv4A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrjeeggdehiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvufgtsehttdertderredtnecuhfhrohhmpedfkggrtghk ucghvghinhgsvghrghdfuceoiigrtghksehofihlfhholhhiohdrohhrgheqnecuggftrf grthhtvghrnhephfeuhfevueffteffgfejtefgkeekheeftdeflefgheffffevheekleef gfehffdunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epiigrtghksehofihlfhholhhiohdrohhrgh X-ME-Proxy: Feedback-ID: i876146a2:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 9AF48272007B; Mon, 31 Jul 2023 10:40:42 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-592-ga9d4a09b4b-fm-defalarms-20230725.001-ga9d4a09b Mime-Version: 1.0 Message-Id: <39b1ac6b-621f-4702-a438-7d0a861cede6@app.fastmail.com> In-Reply-To: <20230730192605.2423480-1-bugaevc@gmail.com> References: <20230730192605.2423480-1-bugaevc@gmail.com> Date: Mon, 31 Jul 2023 10:40:22 -0400 From: "Zack Weinberg" To: "GNU libc development" Subject: Re: [PATCH v4 0/6] fcntl fortification Content-Type: text/plain X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, Jul 30, 2023, at 3:25 PM, Sergey Bugaev via Libc-alpha wrote: > this is the v4 of the fcntl fortification work. I apologize if this has already been discussed, but I can't find any mention of it. What does this patch do with code that supplies an *unnecessary* third argument to fcntl and/or open? (For example, `open(fname, O_RDONLY, 0)`. I have seen this fairly often and it's harmless, so I think it should probably continue to be allowed. I can see an argument for warning about this, but I think that belongs in the compiler, with a dedicated -W option to squelch it. zw