From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cmx-mtlrgo001.bell.net (mta-mtl-001.bell.net [209.71.208.11]) by sourceware.org (Postfix) with ESMTP id A24B43858C83 for ; Mon, 7 Feb 2022 17:13:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A24B43858C83 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=bell.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bell.net X-RG-CM-BuS: 0 X-RG-CM-SC: 0 X-RG-CM: Clean X-Originating-IP: [70.50.7.94] X-RG-Env-Sender: dave.anglin@bell.net X-RG-Rigid: 61FC530A004C5BD8 X-CM-Envelope: MS4xfGDvy1TjCyrF/8WRQNJfa9Vtr40Hz7Z+vXKViGstNymoD0obTdilnDqVx6fkM0WXSmx/K/mN/xSIo3Yhky5nyvUl2huDFg9Dmdc9GsBj2ii7FCClfPh5 IMCQmvbm1CIS4byk0t9r9SmdXCjjN/7Ydbs8DwZbqQ+pWY0Aa3FCtJsnXH/lZ0uJULk8n9gQX0Gvxnqn3G9XeBt6/DTw20J3/MN5qShKQwxkFIWalkytZROx yC1Wnq5VyZDloz5OdWfB8ynNLdt2U5p7TQpaDvTNAcCcddstx3ot6GNQTezPQbl1Oxl7i/cLuDJ4YPBNMqRW0Z9DvzTHio/gYQgSa+1ezh1L4d+oLlOmOjN+ /r9p2yKF X-CM-Analysis: v=2.4 cv=eZxew5IH c=1 sm=1 tr=0 ts=62015323 a=9k1bCY7nR7m1ZFzoCuQ56g==:117 a=9k1bCY7nR7m1ZFzoCuQ56g==:17 a=IkcTkHD0fZMA:10 a=FBHGMhGWAAAA:8 a=f-fniwLSMdtdmIKvjRUA:9 a=QEXdDO2ut3YA:10 a=9gvnlMMaQFpL9xblJ6ne:22 Received: from [192.168.2.49] (70.50.7.94) by cmx-mtlrgo001.bell.net (5.8.716.03) (authenticated as dave.anglin@bell.net) id 61FC530A004C5BD8; Mon, 7 Feb 2022 12:13:07 -0500 Message-ID: <39e76a97-ed85-0d1a-c1df-b4a34f9db642@bell.net> Date: Mon, 7 Feb 2022 12:13:07 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH v3] hppa: Fix bind-now audit (BZ #28857) Content-Language: en-US To: Andreas Schwab , Adhemerval Zanella via Libc-alpha Cc: John David Anglin , Adhemerval Zanella References: <20220207141511.668554-1-adhemerval.zanella@linaro.org> <87v8xqvfwl.fsf@igel.home> From: John David Anglin In-Reply-To: <87v8xqvfwl.fsf@igel.home> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Feb 2022 17:13:14 -0000 On 2022-02-07 10:46 a.m., Andreas Schwab wrote: > On Feb 07 2022, Adhemerval Zanella via Libc-alpha wrote: > >> +/* Clear the plabel bit to get the actual address of the descriptor. */ >> +#define DL_FIXUP_ADDR_VALUE(addr) \ >> + (*(DL_FIXUP_VALUE_TYPE *) ((unsigned int) (addr) & ~2)) > Why not uintptr_t? > >> +#define DL_FIXUP_BINDNOW_RELOC(value, new_value, st_value) \ >> + *(value) = *(DL_FIXUP_VALUE_TYPE *) ((unsigned int) (new_value) & ~2); > Likewise. Why is there a semicolon? Good suggestions. -- John David Anglin dave.anglin@bell.net