From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by sourceware.org (Postfix) with ESMTPS id 44CF438515E8 for ; Mon, 5 Apr 2021 11:29:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 44CF438515E8 Received: by mail-ej1-x633.google.com with SMTP id e14so16341703ejz.11 for ; Mon, 05 Apr 2021 04:29:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:cc:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fd1TaDjvbmBZz2M+mqHtQN4GQ90FLp/lhYw81eLoFmE=; b=oSXpATcxRUmuCE9Da7rSlH/4GgnGg7R73/JKFRCFLTJjyGE1Mn8ge0o1E+1kgFSowQ O5+ZCa9t2t1wjutJmuaeSrQ7URTmJytQ5W6+zmDfFuxSNZQPUcLnaqR9pGFGDcC4A26U s+V8jjn/2XH68TaBpuQkWa9aqnFAGhNot1sBVGPsfZuzmVissWuglmYk6baaHPLEH4JH +tdJQWjBLb5nGfQw/six4CIxiCG0k1r8knTIO3YgLgpwA82RBDUfPRURow/UuFnXXVqy Zu4opxwjUmesH6zsIeGSlcmdrkR6qIk8Y/4mwAEC7NkyWee6+8lkhFCcdvncoV6524iN tFYg== X-Gm-Message-State: AOAM530cws8icSUOxzTG7+uiP6b7+Gd+nLbNQVhDOdnknfZI06FCcpgP wrkTlMuZQw/mIXOcgX0Hs5aboeoyIdY= X-Google-Smtp-Source: ABdhPJxJVu0AKjV8uTl4Je02md+kixYpZXTCFI1WTAO3EkeNLR0pSZ8DyTI2hXNhC6CB7xK+XUWRGg== X-Received: by 2002:a17:906:2e9a:: with SMTP id o26mr11084284eji.357.1617622182188; Mon, 05 Apr 2021 04:29:42 -0700 (PDT) Received: from ?IPv6:2001:a61:2553:a401:cfc6:2039:a9ec:21ff? ([2001:a61:2553:a401:cfc6:2039:a9ec:21ff]) by smtp.gmail.com with ESMTPSA id mp36sm8298525ejc.48.2021.04.05.04.29.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Apr 2021 04:29:41 -0700 (PDT) Cc: mtk.manpages@gmail.com, linux-man@vger.kernel.org, libc-alpha@sourceware.org Subject: Re: [PATCH v5 10/35] capget.2: Use syscall(SYS_...); for system calls without a wrapper To: Alejandro Colomar References: <20210403194026.102818-1-alx.manpages@gmail.com> <20210404115847.78166-11-alx.manpages@gmail.com> From: "Michael Kerrisk (man-pages)" Message-ID: <3a3118b9-ae7f-5042-c52a-5eaf42c320cc@gmail.com> Date: Mon, 5 Apr 2021 13:29:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210404115847.78166-11-alx.manpages@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Apr 2021 11:29:44 -0000 Hi Alex, On 4/4/21 1:58 PM, Alejandro Colomar wrote: > Signed-off-by: Alejandro Colomar > --- > man2/capget.2 | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) Patch applied. Again, some minor follow-up edits. Thanks, Michael > diff --git a/man2/capget.2 b/man2/capget.2 > index 6de51b72c..a2d897cc7 100644 > --- a/man2/capget.2 > +++ b/man2/capget.2 > @@ -18,14 +18,17 @@ > capget, capset \- set/get capabilities of thread(s) > .SH SYNOPSIS > .nf > -.B #include > +.RB " /* Definition of " CAP_* " and " \ > +_LINUX_CAPABILITY_* " constants */" > +.B #include > +.BR "#include " " /* Definition of " SYS_* " constants */" > +.B #include > .PP > -.BI "int capget(cap_user_header_t " hdrp ", cap_user_data_t " datap ); > -.BI "int capset(cap_user_header_t " hdrp ", const cap_user_data_t " datap ); > +.BI "int syscall(SYS_capget, cap_user_header_t " hdrp , > +.BI " cap_user_data_t " datap ); > +.BI "int syscall(SYS_capset, cap_user_header_t " hdrp , > +.BI " const cap_user_data_t " datap ); > .fi > -.PP > -.IR Note : > -There are no glibc wrappers for these system calls; see NOTES. > .SH DESCRIPTION > These two system calls are the raw kernel interface for getting and > setting thread capabilities. > @@ -40,7 +43,7 @@ The portable interfaces are > .BR cap_set_proc (3) > and > .BR cap_get_proc (3); > -if possible, you should use those interfaces in applications. > +if possible, you should use those interfaces in applications; see NOTES. > .\" > .SS Current details > Now that you have been warned, some current kernel details. > @@ -239,9 +242,6 @@ No such thread. > .SH CONFORMING TO > These system calls are Linux-specific. > .SH NOTES > -Glibc does not provide a wrapper for this system call; call it using > -.BR syscall (2). > -.PP > The portable interface to the capability querying and setting > functions is provided by the > .I libcap > -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/