From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by sourceware.org (Postfix) with ESMTPS id 1BA4E3858401 for ; Wed, 4 Oct 2023 15:44:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1BA4E3858401 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1696434281; x=1697039081; i=volker.weissmann@gmx.de; bh=WNYgvQ1NtuVvGYnvpcuGyHUIXojjmTYyuL+xfKb2xu0=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=iabnk2B8i95h7zF/zfhccPSGMnkn2fRy0XciTgKq8VguMZ8/FO8U/ZrWl7XD4VgD9rMQ7w0bobd ridhe81iytW/iuDDmq9mT+C4YeNxiBwaIBUcVT09s+FrR/MFs2IwQev5cs/QwbLyUiKR38j5bvWWJ 1ULj9Ou0+s/h9l/xZAxsNHhqMDwOYsGDfM959PD50ljTYYiwnOVUNZ60wu0VRzpFxaPY0PCVqUuAs ++VrME15VCNLpCb1gtpiDF5s4YmihpP7FcfPaCTm4iR+uZEEdZNQ/aWhKrqpJh8bqETF8ojSmLpjH Gy+UFnranqDs9RbCsZ8oeZRmPv1htdevYNNA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.178.51] ([46.5.231.100]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MwwZX-1rYTo20k8p-00yUcs; Wed, 04 Oct 2023 17:44:41 +0200 Message-ID: <3a3f7a95-bc8f-4641-86e6-8df6d80eb6b3@gmx.de> Date: Wed, 4 Oct 2023 17:44:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] Fix FORTIFY_SOURCE false positive Content-Language: en-US To: Andreas Schwab Cc: libc-alpha@sourceware.org References: <20231003171844.9586-1-volker.weissmann@gmx.de> From: =?UTF-8?Q?Volker_Wei=C3=9Fmann?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:N7EfhD4qy8DnbM0fSTuRwYPRv432PwiNIh2nGhYocqoPpSaj82s QVh24OG7ZpoWQRCFeSkNQbfI7zkC6le0/Q63svph3PbNM+yp9mIn1iIhwlURccOUlvWmK+W oTxlUjFNXJw1/OcEEJK8uFFqMZV5I341Kg8iHMR4cnG89L3MJ7c7oIG7sseH5XOM5AzOPTx Xbs+VfQoKhIRMskxcXzDQ== UI-OutboundReport: notjunk:1;M01:P0:t8ojobStLgQ=;7P+q3jVt04O4sTigAsTvPOZKFDn Sr6yv5vq6RhnD+FgRm3bamp8QGkXm1kiuKSeTrlwcGr7YcHZZsU2A8w8b42G8QPOhXl2aNPYX pWYc+6YrYNki1IpTwsgtniCvs+kHw14KCZmkXZiP0BHl6JJVBz7C3nRxiZRK2X6XWB8Bvfura R7qo5Ca+YekWKojOUbZ4/p27CbrrPNMqupyqpTpLNR49puBUORqXBou4IniuSaBQTQy63B34d +UKh1lVWHNAkf2crq+uMbn28QXUhyHEDQq4Qpp1trS/bJtEX6dn6Fh3YdYAPQePzKpyNcqfeq i/btgbABFUB4RmO21S6V0Gq/bakGdrmBF8kXYvTutismfpYkP6WcCXSrPglkFjIuSsjlzzG/B hrgdSd+x8dgNyIv+Z7QzHJDLUc+PM8cfuzDjfh2t7d54gvLHD3aATGzwsgGpWxhwF7+LE5ttI p/lw4ZB13CNkK5oCAINvPYeSrygy+HuRygkOvt6VEMyXexEQW8+4XRemFLGNhv/BzG1xplY3/ OgL6AxvL9qt24isl6sgqo7cV6gtUFo43MODpS2nN3YLFbVgv+0F2IKFv1HEzyuQqJmGL+h0g9 f82q8SOie4wdtPNfRBgQNlRoY3lnOPIg2kR1BZUnpKMQkNdZX0nW1oNlgUWPmCRgyhYDMhl+N EAGN6jwlqYNL9TrCDA9Fel2OqNfZgg0XUZa6cVSdRXbjD+jtQqEfLFknvBnPNAbHw8dMVJMAl lwDj/d5kBNv4T0zRrPYX4RjdTu/qG4YHV9YvLp34+k8SAtVaz0NqLnZvQOMvMUfvplBxTsjYm uDNhUSLWuZIREmbjM+wUj5GSoWXWtEpxk5B3DcZS/8C5nHw0jNCxHDMSIwDDS1KJqpRFOYGMw 3L32M923Br/bOEjR855CtTXG+HOnf5VNy8XWrGo4fWBf4SsHslUhW3qE78gFwfKca6eGxgU6E 9h++vw== X-Spam-Status: No, score=-14.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Yes, you are right. I will write a patch once we decided whether we want to "return 1" or __libc_fatal ("*** too many open file descriptors ***\n") On 04.10.23 16:51, Andreas Schwab wrote: > On Okt 03 2023, Volker Wei=C3=9Fmann wrote: > >> diff --git a/sysdeps/unix/sysv/linux/readonly-area.c b/sysdeps/unix/sys= v/linux/readonly-area.c >> index edc68873f6..ba32372ebb 100644 >> --- a/sysdeps/unix/sysv/linux/readonly-area.c >> +++ b/sysdeps/unix/sysv/linux/readonly-area.c >> @@ -42,7 +42,9 @@ __readonly_area (const char *ptr, size_t size) >> to the /proc filesystem if it is set[ug]id. There has >> been no willingness to change this in the kernel so >> far. */ >> - || errno =3D=3D EACCES) >> + || errno =3D=3D EACCES >> + /* Process has reached the maximum number of open files. */ >> + || errno =3D=3D EMFILE) > Should this also handle ENFILE? >