From: Florian Weimer <fweimer@redhat.com>
To: "Joseph S. Myers" <joseph@codesourcery.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] Disallow use of DES encryption functions in new programs.
Date: Thu, 28 Jun 2018 13:10:00 -0000 [thread overview]
Message-ID: <3a52c33f-32af-b30c-4a1e-19cf65be5aac@redhat.com> (raw)
In-Reply-To: <20180625134328.642DC43994575@oldenburg.str.redhat.com>
On 06/25/2018 03:43 PM, Florian Weimer wrote:
> diff --git a/conform/data/stdlib.h-data b/conform/data/stdlib.h-data
> index d8fcccc2fb..6913828196 100644
> --- a/conform/data/stdlib.h-data
> +++ b/conform/data/stdlib.h-data
> @@ -149,9 +149,6 @@ function {unsigned short int*} seed48 (unsigned short int[3])
> #if !defined ISO && !defined ISO99 && !defined ISO11 && !defined POSIX && !defined XPG4 && !defined XPG42 && !defined UNIX98
> function int setenv (const char*, const char*, int)
> #endif
> -#if !defined ISO && !defined ISO99 && !defined ISO11 && !defined POSIX && !defined POSIX2008
> -function void setkey (const char*)
> -#endif
> #if !defined ISO && !defined ISO99 && !defined ISO11 && !defined XPG4 && !defined POSIX && !defined POSIX2008
> function {char*} setstate (char*)
> #endif
> diff --git a/conform/data/unistd.h-data b/conform/data/unistd.h-data
> index ddf4f25132..aa070528e8 100644
> --- a/conform/data/unistd.h-data
> +++ b/conform/data/unistd.h-data
> @@ -437,9 +437,6 @@ function int chroot (const char*)
> function int chown (const char*, uid_t, gid_t)
> function int close (int)
> function size_t confstr (int, char*, size_t)
> -#if !defined POSIX && !defined POSIX2008
> -function {char*} crypt (const char*, const char*)
> -#endif
> #if defined XPG4 || defined XPG42 || defined UNIX98
> function {char*} ctermid (char*)
> function {char*} cuserid (char*)
> @@ -449,9 +446,6 @@ allow cuserid
> #endif
> function int dup (int)
> function int dup2 (int, int)
> -#if !defined POSIX && !defined POSIX2008
> -function void encrypt (char[64], int)
> -#endif
> function int execl (const char*, const char*, ...)
> function int execle (const char*, const char*, ...)
> function int execlp (const char*, const char*, ...)
Joseph, do you think the above changes are correct? Or was crypt a
non-optional part of any of the standards at one point?
There is not much we can do about encrypt and setkey, though, if it was
mandatory. We really want to get rid of that.
Thanks,
Florian
next prev parent reply other threads:[~2018-06-28 13:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 13:43 Florian Weimer
2018-06-28 13:10 ` Florian Weimer [this message]
2018-06-28 16:01 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a52c33f-32af-b30c-4a1e-19cf65be5aac@redhat.com \
--to=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).