public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Xiaoming Ni <nixiaoming@huawei.com>,
	aurelien@aurel32.net, eggert@cs.ucla.edu,
	joseph@codesourcery.com, zackw@panix.com,
	libc-alpha@sourceware.org
Cc: wangle6@huawei.com
Subject: Re: [PATCH v2] setrlimit/getrlimit: Use __nonnull to avoid null pointer
Date: Wed, 10 Feb 2021 08:48:07 -0300	[thread overview]
Message-ID: <3a562fbd-8b0a-6122-faa2-4aa3f753fd40@linaro.org> (raw)
In-Reply-To: <e74d8b23-eb10-0051-2f07-edf46e3c5190@linaro.org>



On 25/01/2021 14:36, Adhemerval Zanella wrote:
> 
> 
> On 04/01/2021 01:07, Xiaoming Ni wrote:
>> Add __nonnull((2)) to the setrlimit()/getrlimit() function declaration
>> to avoid null pointer access.
>>
>> -----
>> v2
>>   According to the suggestions of the Adhemerval Zanella and Zack Weinberg:
>>     use __nonnull() to check null pointers in the compilation phase.
>>     do not add pointer check code to setrlimit()/getrlimit().
>>     The validity of the "resource" parameter is checked in the syscall.
>> v1
>>   https://public-inbox.org/libc-alpha/20201230114131.47589-1-nixiaoming@huawei.com/
> 
> LGTM, ok for *2.34*.
> 
> Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

I push it upstream, thanks for the patch.

      reply	other threads:[~2021-02-10 11:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-04  4:07 Xiaoming Ni
2021-01-21 13:35 ` ping // " Xiaoming Ni
2021-01-25 17:36 ` Adhemerval Zanella
2021-02-10 11:48   ` Adhemerval Zanella [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3a562fbd-8b0a-6122-faa2-4aa3f753fd40@linaro.org \
    --to=adhemerval.zanella@linaro.org \
    --cc=aurelien@aurel32.net \
    --cc=eggert@cs.ucla.edu \
    --cc=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    --cc=nixiaoming@huawei.com \
    --cc=wangle6@huawei.com \
    --cc=zackw@panix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).