From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) by sourceware.org (Postfix) with ESMTPS id A8A863858D3C for ; Tue, 4 Jan 2022 12:34:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A8A863858D3C Received: by mail-qt1-x836.google.com with SMTP id l17so33826405qtk.7 for ; Tue, 04 Jan 2022 04:34:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ZBXwJJkryUAoL2GPc5mevuLD0ebL+dNtzC58GHFiG8M=; b=Cg80n6Ga24FqUKghFmPBKBPOr9pyfD5c1U+mpR70JO38cCFR+g//vyZUCbFFWkwYXI M9sBnUDeojT9xYBaLAC01nvrkbR2o/HucUunkp8rqYIDC48iLA+7wMXbUBti82C4EEig 3RJksH5SL1EQRzR9xjzTswvgidSO9fsfDvWUo5gny2vOn4pMII8WxStwGUlfpWkzowVd 0d2Rhj0jAQWDUh1lCwCROXfn2X/8Wuv4iMVTl9lWdxnIl/My/wx/m+02SzpEC9cN313a I7tiCpzyOuszXK6hXoqe+kG2duX14KRg9MG4pJbWIgDyqTLSo2QEKqyjGAeVXuYAz0Ce eEAA== X-Gm-Message-State: AOAM533Ao0Y7KWe1Irb4T8jHnhDsc3MLCvDdl35qgnIqW1aWDeNnzu8y KexaQYVQsWcI1IL6+fDAep1kFJbbTrfZTA== X-Google-Smtp-Source: ABdhPJyJPSss8rkviOrmXaNRrv8P/EACURTMC2dMdgi1tUpEH2cvVsVSbdSffR2in6sXRUHN9mNVLQ== X-Received: by 2002:a05:622a:1307:: with SMTP id v7mr44550413qtk.536.1641299690187; Tue, 04 Jan 2022 04:34:50 -0800 (PST) Received: from ?IPV6:2804:431:c7ca:a350:1960:9a87:fba4:a664? ([2804:431:c7ca:a350:1960:9a87:fba4:a664]) by smtp.gmail.com with ESMTPSA id e20sm34079923qty.14.2022.01.04.04.34.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jan 2022 04:34:50 -0800 (PST) Message-ID: <3b11ca1a-e0c6-9245-d91a-6d987e9e40fd@linaro.org> Date: Tue, 4 Jan 2022 09:34:47 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v5 00/13] Glibc OpenRISC port Content-Language: en-US To: Stafford Horne , GLIBC patches Cc: Openrisc References: <20220104031414.2416928-1-shorne@gmail.com> From: Adhemerval Zanella In-Reply-To: <20220104031414.2416928-1-shorne@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jan 2022 12:34:52 -0000 On 04/01/2022 00:14, Stafford Horne via Libc-alpha wrote: > This is the OpenRISC port for glibc that I have been working on. > > Changes since v4: > - Fix suggestion from Joseph Myers > - Remove libnsl.abilist > - Fixed suggestions from Adhemerval: > - Use Elf32_Addr and Elf32_Sym on link.h and sotruss-lib.c. > - Remove the superflous atomic typedefs on atomic-machine.h. > - Add the _dl_find_object on libc.abilist. > - Update wording for the NEWS entry. > - Other fixes > - Update date to 2022 > - Remove uneeded REGSIZE > - Remove trailing newlines in Makefile > - Fix space vs tabs indentation in sysdep.h > > Changes since v3: > - Fix suggestion from Paul Eggert > - Fix typo pore/port > - Fixed suggestions from Adhemerval: > - Used ENTRY/END asm macros where missing > - Remove block in dl-machine.h suggesting LD_PROFILE > - Remove jmp_buf-macros.h macros and use new default. > - Remove tcb-offsets.sym file and Makefile reference. > - Remove tcb-offsets.h include in tls.h. > - Define lib-audit register layout inline with other architectures. > - Fix usage of locally defined register in or1k_get_got. Also, fixup > indentation when using or1k_get_got. > - Cleanup abilists after rebasing, adding rseq and removing > empty files. > - Remove prctl and other unused entries in the linux Makefile. > - Fix STACK_ALIGN to 4 bytes, from incorrect copy-n-paste 16 bytes. > - Use default pthreadtypes-arch.h. > - Mention only soft-float supported in NEWS. > - Remove sysdeps/unix/sysv/linux/or1k/bits/timesize.h and use new > default. > > Changes since v2: > - Fixed suggestions from Joseph Myers: > - Fix comment style, and description on top of each file > - Make sure macros have parentheses when needed, > - Bump required kernel down to 5.4.0 and document > - Regenerate arch-syscall.h > - Fixed suggestions from Adhemerval: > - Remove kernel_stat.h > - Just set MMAP2_PAGE_UNIT to 8K > - Remove ioctl.c and syscall.c files > - Update TCB alignment to 32 bytes > > Changes since v1: > - Update api's as suggested by Florian > - Remove hard float support > - Updates to get all tests passing > - Split patch into managable bits similar to recent ARC port > > Documentation: > > Architecture / ABI docs: > https://raw.githubusercontent.com/openrisc/doc/master/openrisc-arch-1.3-rev1.pdf > > Test Results: > > build-many-glibcs.py: > > PASS with mainline ang gcc-11. > > Full test suite: > > This time I ran the test suite with timeout of 300 and with patch for forcing > O_LARGEFILE in open64 [0]. The test has one failure but it seems like flaky > test as it passed after the second run. This is already approved, so I take these tests were done against and slight order tree (which is fine btw). > > # results in file: /home/shorne/work/gnu-toolchain/log/test--20211226-162029.log > # test start: 2021-12-26T16:20:29+09:00 > > # failures > FAIL: posix/tst-execveat /* Running second time passes */ > > # test finish: 2021-12-29T12:54:08+09:00 > # test duration: 2 days 20 hours 33 minutes and 39 seconds > # test for file: tests.sum > # test wrapper: /home/shorne/work/gnu-toolchain/glibc/scripts/cross-test-ssh.sh --timeoutfactor 300 10.0.0.5 > > # summary > 1 FAIL > 4148 PASS > 31 UNSUPPORTED > 16 XFAIL > 2 XPASS > > posix/tst-execveat.out: > Timed out: killed the child process > Termination time: 2021-12-29T01:02:42.433964340 > Last write to standard output: 2021-12-28T23:22:40.266363000 > > tests.sum: https://gist.github.com/stffrdhrn/88c1fce0c54350258f1f5869068d015a > > [0] https://sourceware.org/pipermail/libc-alpha/2021-December/134634.html > I approved the missing patch and I think the patches are ok to go in. I am curious about the posix/tst-execveat issues, but since it does not really have any arch-specific implementation I think it might be related to the test environment (it would be good to know exactly what has caused the failure so we can improve it).