From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf31.google.com (mail-qv1-xf31.google.com [IPv6:2607:f8b0:4864:20::f31]) by sourceware.org (Postfix) with ESMTPS id 8E4973858C2C for ; Tue, 4 Jan 2022 14:27:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8E4973858C2C Received: by mail-qv1-xf31.google.com with SMTP id q4so34455658qvh.9 for ; Tue, 04 Jan 2022 06:27:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=hyLKtYVckqfCash+O4b+5wffseLXC9VTZfF8TTxy8yY=; b=FXxZqeFmcm0H33vtgdiIJAiXP8iFUxc9FxeRATAF3coxns6nk/0L08Lc72zKJbhVX2 kzrVDJmfjCx9jUbQ4a9iIrN3fJGI0iHHHwdlIdP5O0wlsbbymmtC4eCcTl16MVXVVPfe vC8t7/jsGE35cFa8jMHdUMk92xAeHAZnbPTitsR96k6TkA4CGiJsNiiDNuEM/1qvi3dZ 15msK8lZg7/iffKq929TNFnsaSc8j3YzU0220toqKElOII6uJ1qrIYtdilXxGbbLEeje 5GJG48L0k6tFSL+Ab7rw16176szpEixv2s+diSynwLEES8TIqXqnbxsmMyjPnQeo9am/ ko0A== X-Gm-Message-State: AOAM533iX+bwDxJsqoaYkqq/R+Xlyc7+nM7Tavaq1URB1Egl8qFMrcuA JJ5LmrqNnGhjLSQo9q4ncetoEg== X-Google-Smtp-Source: ABdhPJzNiQ2LfrtNR2n9K+sv9ExVshJZb8Y+DqOunGGBlSUwGgmbQ0F72VL06heNecQmCbkvLae6rg== X-Received: by 2002:ad4:5e89:: with SMTP id jl9mr5962784qvb.43.1641306475041; Tue, 04 Jan 2022 06:27:55 -0800 (PST) Received: from ?IPV6:2804:431:c7ca:a350:1960:9a87:fba4:a664? ([2804:431:c7ca:a350:1960:9a87:fba4:a664]) by smtp.gmail.com with ESMTPSA id r187sm28922734qke.11.2022.01.04.06.27.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jan 2022 06:27:54 -0800 (PST) Message-ID: <3b630aac-4a2a-76a4-483f-3bbcef8297cf@linaro.org> Date: Tue, 4 Jan 2022 11:27:52 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v2 10/14] LoongArch: Linux Startup and Dynamic Loading Code Content-Language: en-US To: caiyinyu , libc-alpha@sourceware.org Cc: xuchenghua@loongson.cn, joseph_myers@mentor.com References: <20211231064455.1030051-1-caiyinyu@loongson.cn> <20211231064455.1030051-11-caiyinyu@loongson.cn> From: Adhemerval Zanella In-Reply-To: <20211231064455.1030051-11-caiyinyu@loongson.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, KAM_STOCKGEN, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jan 2022 14:27:57 -0000 On 31/12/2021 03:44, caiyinyu wrote: > This contains the Linux-specific code for loading programs on LoongArch. > --- > sysdeps/unix/sysv/linux/loongarch/dl-static.c | 80 +++++++++++++++++++ > sysdeps/unix/sysv/linux/loongarch/ldsodefs.h | 33 ++++++++ > 2 files changed, 113 insertions(+) > create mode 100644 sysdeps/unix/sysv/linux/loongarch/dl-static.c > create mode 100644 sysdeps/unix/sysv/linux/loongarch/ldsodefs.h > > diff --git a/sysdeps/unix/sysv/linux/loongarch/dl-static.c b/sysdeps/unix/sysv/linux/loongarch/dl-static.c > new file mode 100644 > index 0000000000..b9a7b2a61f > --- /dev/null > +++ b/sysdeps/unix/sysv/linux/loongarch/dl-static.c > @@ -0,0 +1,80 @@ > +/* dl_static_init for loongarch. > + Copyright (C) 2021 Free Software Foundation, Inc. > + > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library. If not, see > + . */ > + > +#include > + > +#ifdef SHARED > + > +void > +_dl_var_init (void *array[]) > +{ > + /* It has to match "variables" below. */ > + enum > + { > + DL_PAGESIZE = 0 > + }; > + > + GLRO (dl_pagesize) = *((size_t *) array[DL_PAGESIZE]); > +} > + > +#else > + > +static void *variables[] = {&GLRO (dl_pagesize)}; > + > +static void _dl_unprotect_relro (struct link_map *l) > +{ > + ElfW (Addr) start = ((l->l_addr + l->l_relro_addr) > + & ~(GLRO (dl_pagesize) - 1)); > + ElfW (Addr) end = ((l->l_addr + l->l_relro_addr + l->l_relro_size) > + & ~(GLRO (dl_pagesize) - 1)); > + > + if (start != end) > + __mprotect ((void *) start, end - start, PROT_READ | PROT_WRITE); > +} > + > +void dl_static_init (struct link_map *l) > +{ > + struct link_map *rtld_map = l; > + struct r_scope_elem **scope; > + const ElfW (Sym) *ref = NULL; > + lookup_t loadbase; > + void (*f) (void *[]); > + size_t i; > + > + loadbase = _dl_lookup_symbol_x ("_dl_var_init", l, &ref, l->l_local_scope, > + NULL, 0, 1, NULL); > + > + for (scope = l->l_local_scope; *scope != NULL; scope++) > + for (i = 0; i < (*scope)->r_nlist; i++) > + if ((*scope)->r_list[i] == loadbase) > + { > + rtld_map = (*scope)->r_list[i]; > + break; > + } > + > + if (ref != NULL) > + { > + f = (void (*) (void *[])) DL_SYMBOL_ADDRESS (loadbase, ref); > + _dl_unprotect_relro (rtld_map); > + f (variables); > + _dl_protect_relro (rtld_map); > + } > +} > + > +#endif This file should not be required, Florian has refactored it to avoid this boilerplate code (check bdc90abc48f0528588600df37eebdc04ce01b2f0 and related commits). > diff --git a/sysdeps/unix/sysv/linux/loongarch/ldsodefs.h b/sysdeps/unix/sysv/linux/loongarch/ldsodefs.h > new file mode 100644 > index 0000000000..680baf2edc > --- /dev/null > +++ b/sysdeps/unix/sysv/linux/loongarch/ldsodefs.h > @@ -0,0 +1,33 @@ > +/* Run-time dynamic linker data structures for loaded ELF shared objects. > + Copyright (C) 2021 Free Software Foundation, Inc. > + > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library. If not, see > + . */ > + > +#ifndef _LDSODEFS_H > + > +/* Get the real definitions. */ > +#include_next > + > +/* Now define our stuff. */ > + > +/* We need special support to initialize DSO loaded for statically linked > + binaries. */ > +extern void _dl_static_init (struct link_map *map); > +#undef DL_STATIC_INIT > +#define DL_STATIC_INIT(map) _dl_static_init (map) > + > +#endif /* ldsodefs.h */ Same as before.