From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126171 invoked by alias); 22 Aug 2019 12:55:23 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 126050 invoked by uid 89); 22 Aug 2019 12:55:22 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mail-qt1-f196.google.com Return-Path: Subject: Re: [PATCH 02/12] Change most internal uses of __gettimeofday to __clock_gettime. To: Paul Eggert , libc-alpha@sourceware.org Cc: Joseph Myers , Florian Weimer , Lukasz Majewski , Alistair Francis , Stepan Golosunov , Arnd Bergmann References: <20190820132152.24100-1-zackw@panix.com> <20190820132152.24100-3-zackw@panix.com> <0632b772-8e4d-bc02-8af9-82adf0c0ee11@cs.ucla.edu> From: Zack Weinberg Openpgp: preference=signencrypt Message-ID: <3bb81bf2-4338-7acb-c4ec-3d8176bd6134@panix.com> Date: Thu, 22 Aug 2019 12:55:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <0632b772-8e4d-bc02-8af9-82adf0c0ee11@cs.ucla.edu> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2019-08/txt/msg00608.txt.bz2 On 8/20/19 2:53 PM, Paul Eggert wrote: > Zack Weinberg wrote: >> +      long int end = (now.tv_sec * 1000 + usectmo + >> +                      (now.tv_nsec + 500000) / 1000000); > > The usual GNU style is to put that trailing "+" at the start of the next > line instead, here and elsewhere. Thanks, will fix. (I've been working a lot on code that uses the other convention recently.) >> -            tm.tm_hour, tm.tm_min, tm.tm_sec, (int) tv.tv_usec); >> +            tm.tm_hour, tm.tm_min, tm.tm_sec, (int) tv.tv_nsec / 1000); >>  } > > Since the goal of this test code is to print the timestamp, the code > should simply use %09d in the format and not divide by 1000. Yeah, OK. zw