From: Siddhesh Poyarekar <siddhesh@gotplt.org>
To: Richard Henderson <rth@twiddle.net>, libc-alpha@sourceware.org
Subject: Re: [PATCH 2/3] Add hidden_proto for getauxval
Date: Fri, 09 Jun 2017 05:55:00 -0000 [thread overview]
Message-ID: <3bc5de17-f6ed-2ab0-d6a0-c952a359b983@gotplt.org> (raw)
In-Reply-To: <20170608225728.26779-3-rth@twiddle.net>
On Friday 09 June 2017 04:27 AM, Richard Henderson wrote:
> ---
> include/sys/auxv.h | 2 ++
> misc/getauxval.c | 1 +
> 2 files changed, 3 insertions(+)
>
> diff --git a/include/sys/auxv.h b/include/sys/auxv.h
> index dede2c3..2e1f86b 100644
> --- a/include/sys/auxv.h
> +++ b/include/sys/auxv.h
> @@ -1 +1,3 @@
> #include <misc/sys/auxv.h>
> +
> +libc_hidden_proto (getauxval)
> diff --git a/misc/getauxval.c b/misc/getauxval.c
> index c83fbce..458f58d 100644
> --- a/misc/getauxval.c
> +++ b/misc/getauxval.c
> @@ -43,3 +43,4 @@ __getauxval (unsigned long int type)
> }
>
> weak_alias (__getauxval, getauxval)
> +libc_hidden_weak (getauxval)
This is fine, but you could just merge this into 3/3 (where this gets
used first), which I won't review since I haven't looked at a powerpc
box in anger for years :)
Siddhesh
next prev parent reply other threads:[~2017-06-09 5:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-08 22:57 [PATCH 0/3] Add some missing cache infomation Richard Henderson
2017-06-08 22:57 ` [PATCH 2/3] Add hidden_proto for getauxval Richard Henderson
2017-06-09 5:55 ` Siddhesh Poyarekar [this message]
2017-06-09 6:58 ` Florian Weimer
2017-06-09 17:45 ` Richard Henderson
2017-06-09 17:49 ` Florian Weimer
2017-06-09 22:11 ` Richard Henderson
2017-06-08 22:57 ` [PATCH 1/3] Guess L1 cache linesize for aarch64 Richard Henderson
2017-06-09 5:51 ` Siddhesh Poyarekar
2017-06-09 5:52 ` Andrew Pinski
2017-10-10 7:24 ` Siddhesh Poyarekar
2017-10-10 10:20 ` Szabolcs Nagy
2017-10-10 10:37 ` Siddhesh Poyarekar
2017-10-10 11:01 ` Szabolcs Nagy
2017-10-10 11:56 ` Siddhesh Poyarekar
2017-10-10 14:20 ` Richard Henderson
2017-10-11 5:28 ` Siddhesh Poyarekar
2017-10-10 17:19 ` Szabolcs Nagy
2017-06-08 22:57 ` [PATCH 3/3] Add cache info for powerpc64 Richard Henderson
2017-06-09 6:59 ` Florian Weimer
2017-06-09 13:12 ` Tulio Magno Quites Machado Filho
2017-06-09 20:07 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3bc5de17-f6ed-2ab0-d6a0-c952a359b983@gotplt.org \
--to=siddhesh@gotplt.org \
--cc=libc-alpha@sourceware.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).