From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by sourceware.org (Postfix) with ESMTP id A4092384B821 for ; Thu, 9 Jul 2020 15:08:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A4092384B821 Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-274-G6Gx4tAfNbW93KKUlnwBEA-1; Thu, 09 Jul 2020 11:08:11 -0400 X-MC-Unique: G6Gx4tAfNbW93KKUlnwBEA-1 Received: by mail-qk1-f199.google.com with SMTP id 204so1973649qki.20 for ; Thu, 09 Jul 2020 08:08:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=MHTg4WVo7KU9HW9IwG8aUKl/PKamX8yD7OTHOYmqRig=; b=l2aaL62RI9DjVZs8q1B//SgSkRYbtplu+7cE7vKyqQmIY5HDNwoRTxZWJXG7jnP5Bc irNh10sDkFxli2Bws9q0pLe1czRgOpzTkcTaMQknCCmtaN3WHC1Go4O/7alfaVEchZlF 5HhHKWxH9MMmt10en9QgIeeJvIX14zZNZRnZf5qLH3LVAt5J8Y4C/kcjdYyLIRL0DhAE VGXsoK1FCODZeX8qe4fUFYLy9nkyVwz1fobUo35mfila+A4z1YRYAlNP6Xt7NuKXD/sF E6EDm8Dt5TO8EHTpPu9ghKTK7+LEibnLpVyrAQwJHLm4cUrj8jetNGt6JFIIrKSYwxQ3 NB8g== X-Gm-Message-State: AOAM530A6frUw7Sy6PZbYm4ooKAnydYj88fIFCwFoeLBZmaQTDZUyIGq FBh6HxPxXVfgcPH+v5dHRzhOnSwvEeYXxL3hG7E42OkbeCx04o/rPMB2tg+JH/TyatiIcnWMVLa 61Zx8AiSOI7brmANblFqO X-Received: by 2002:ac8:130d:: with SMTP id e13mr66319769qtj.253.1594307290794; Thu, 09 Jul 2020 08:08:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzm2i9wqS7p8awAlF3JbVL5bRkpJcfHT1Yx0No/z5WDOpksQVa0i/vzGFFhMmYV2MBo7xm51A== X-Received: by 2002:ac8:130d:: with SMTP id e13mr66319730qtj.253.1594307290471; Thu, 09 Jul 2020 08:08:10 -0700 (PDT) Received: from [192.168.1.4] (198-84-170-103.cpe.teksavvy.com. [198.84.170.103]) by smtp.gmail.com with ESMTPSA id e129sm4163331qkf.132.2020.07.09.08.08.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jul 2020 08:08:09 -0700 (PDT) Subject: Re: [PATCH] linux: Fix syscall list generation instructions To: "Maciej W. Rozycki" , libc-alpha@sourceware.org References: From: Carlos O'Donell Organization: Red Hat Message-ID: <3be1913c-c4f1-0703-46b9-cad43e6ed2e7@redhat.com> Date: Thu, 9 Jul 2020 11:08:09 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jul 2020 15:08:15 -0000 On 7/9/20 12:40 AM, Maciej W. Rozycki wrote: > Make the instructions for syscall list generation match Makefile and > refer to `update-syscall-lists'; there has been no `update-arch-syscall' > target. Also use single quotes around the command to stick to the ASCII > character set. > > Fixes 4cf0d223052d ("Linux: Add tables with system call numbers"). > --- > As a fix to a Makefile comment only I trust it is fine to apply even in > the freeze period. OK to push then? > > Maciej > --- > sysdeps/unix/sysv/linux/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > glibc-update-syscall-lists.diff > Index: glibc/sysdeps/unix/sysv/linux/Makefile > =================================================================== > --- glibc.orig/sysdeps/unix/sysv/linux/Makefile > +++ glibc/sysdeps/unix/sysv/linux/Makefile > @@ -26,7 +26,7 @@ ifndef subdir > # architecture-specific system call names. > # > # To bootstrap a new architecture, create an empty file in the right > -# place and run ?make update-arch-syscall? from the top-level of a > +# place and run `make update-syscall-lists' from the top-level of a > # configured, but not-yet-built glibc tree. > # > # --lock points to a file not replaced during the update operation, so > This is trivial and Allistair gave a reivew. Please commit if you haven't already. -- Cheers, Carlos.