From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bat.birch.relay.mailchannels.net (bat.birch.relay.mailchannels.net [23.83.209.13]) by sourceware.org (Postfix) with ESMTPS id 875833857C4A for ; Thu, 17 Mar 2022 05:11:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 875833857C4A X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id EC0E14613A9; Thu, 17 Mar 2022 05:11:49 +0000 (UTC) Received: from pdx1-sub0-mail-a305.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 95AEE4611FD; Thu, 17 Mar 2022 05:11:46 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1647493909; a=rsa-sha256; cv=none; b=ciVLpGdXU3nR9xUAWMqZoL64TQnS6mXKCbjnRK/Ywk4KUpnK2uNBl/wHV7416BgKd1ga1d q7t5dYX0ZInLVpH4IP8GcvA5RM3Ng4IQgyQjV5BRcTn93acRuL524Ms1j0TTRZjmV2D65X Llcpl4kc0+T6QbZOdlPjSD9E1Ni6GcPXtIwAxdjCPFUeHkN7Fh17wNWUBaZeDej6udbjmS vFZp2YmB5oTnty1AbxTWXG4Tg+S/Ip1ekbrAU63GQMWOv+/u4Rqof8sXlt7uJHS9Lvbk3m 3qboCxndoE/uvQdWRsrYH+tMLcngjkmd/eZLtBZ0RUDOtkO47XODqdjBoMikJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1647493909; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7ITECe+FRzIjqLbRrxOH+WbD1wKg+G4dA0EP8w9ZmLE=; b=fWXiHYtHp46XRWNUkAYzrHBG8HwPw3CAucJFKT+1BRPLMq9KARwSRPlqCLUjnwYWRT6x+z isECfMSoIyYoNv65feeyPrRtAifISL7Ds5OKUvwdlhwHwJfwt5BgGatSAJP2Z7RTCkme9t 4ySxEQC8bqfp2SonVMz8+FEl8J8Q75Gnm575l3z61rA9y3bmgUbt13hR4fyINHNZkpSQd8 +B6JtaQDXH/j5dOiPimsO7yfhs7qcdNKX/Yzq/IYmKmxesQoDQZ/lldeimlFWb7nxyWN35 rO1XjnXxWvvMzAlLHJW5dr4xecZQHLhayyM7XSIuZdInNygHOYNY/rEx5dcomw== ARC-Authentication-Results: i=1; rspamd-c9cb649d9-7z8x4; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@sourceware.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a305.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.102.3.17 (trex/6.5.3); Thu, 17 Mar 2022 05:11:49 +0000 X-MC-Relay: Junk X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Ruddy-Squirrel: 5377dec83b4284a4_1647493909845_4174947403 X-MC-Loop-Signature: 1647493909845:4234681121 X-MC-Ingress-Time: 1647493909844 Received: from [192.168.1.174] (unknown [1.186.123.88]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a305.dreamhost.com (Postfix) with ESMTPSA id 4KJwGp1BCDz1b; Wed, 16 Mar 2022 22:11:29 -0700 (PDT) Message-ID: <3be886f2-b25e-eca1-4c7f-bec58f4cb01d@sourceware.org> Date: Thu, 17 Mar 2022 10:41:23 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 11/12] gaih_inet: Split result generation into its own function Content-Language: en-US To: DJ Delorie Cc: libc-alpha@sourceware.org References: From: Siddhesh Poyarekar In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3488.4 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_NONE, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, RCVD_IN_SBL, SPF_HELO_NONE, SPF_NEUTRAL, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Mar 2022 05:11:52 -0000 On 17/03/2022 10:35, DJ Delorie wrote: > Siddhesh Poyarekar via Libc-alpha writes: >> Simplify the loop a wee bit and clean up variable names too. > > FYI combining "split out" and "minor changes" makes it harder to review, > because the minor changes are nearly impossible to spot in the large > chunks of "moving". Ack, I got a bit lazy :/ > I had one comment about a leak (see below) but it's independent of this > patch set (maybe?). Yeah, it's a preexisting leak, but it only manifests when the system is out of memory. Thanks, Siddhesh