From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf33.google.com (mail-qv1-xf33.google.com [IPv6:2607:f8b0:4864:20::f33]) by sourceware.org (Postfix) with ESMTPS id BF2A03846402 for ; Wed, 2 Jun 2021 18:00:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BF2A03846402 Received: by mail-qv1-xf33.google.com with SMTP id m6so1792208qvg.1 for ; Wed, 02 Jun 2021 11:00:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uNjHvxlaJq+7xgaJX5Cr4yeK63Z0wfo85kKj80z0tSk=; b=kETwjgLCnxqvYeqtZ+jUxClP6RAylaS/6BeAvgC3+OzeDZoLwYGiqKCPgTx0AP6nss pgRPLQ10UhbW7fwkdiJsnn8rKYCqAI+S178WxkxP6S62Iu4ozhqkh6Lyqef2xSwPfK8a +TfqV28YLOqSh7k8U3RDgizk8iqfaQGcMf1zPFP/TtwA7IhkHVqLxoNmRSnfkbvIWMUO vHScReBvT8yXx44vjnxFv7Dz/JafDOeOLBJOKdmEFFVBsAE4GVCila4czy/CZhYzEEdH j6ohBT7QZUXI7Q0CZ3mY73Lq2XWbzSDqpSueQ+6999nkYwSywgqV2r43MNGp+ESLL/FH xM7Q== X-Gm-Message-State: AOAM53070t7uD2i+4LoeBDfLhQDKnxco3sWHS2bKL6Gt8mAEwGsKGeKP //TeUmUwm1t6+4wnCuR+UA8jpeGVis6Gsg== X-Google-Smtp-Source: ABdhPJzLp7l81YYWmU7AbVdl2086fwoXGhLMvOEc341mTOUoj3QfVOBYENMdDaWnwsg1DHeMaH1CVg== X-Received: by 2002:a0c:eda5:: with SMTP id h5mr9693172qvr.26.1622656836189; Wed, 02 Jun 2021 11:00:36 -0700 (PDT) Received: from [192.168.1.4] ([177.194.59.218]) by smtp.gmail.com with ESMTPSA id k23sm319678qkk.71.2021.06.02.11.00.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jun 2021 11:00:35 -0700 (PDT) Subject: Re: [PATCH 09/16] dlfcn: Move dlmopen into libc To: Florian Weimer Cc: libc-alpha@sourceware.org References: <59a14fc491a58520936da8d69093abf9112a7ffe.1622469908.git.fweimer@redhat.com> <477ae2c4-40ef-a74a-1150-6761b1c7099a@linaro.org> <87a6o8w3zy.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Message-ID: <3be9251c-c91d-e87e-db56-2bd7677bdadb@linaro.org> Date: Wed, 2 Jun 2021 15:00:33 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <87a6o8w3zy.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jun 2021 18:00:38 -0000 On 02/06/2021 14:49, Florian Weimer wrote: > * Adhemerval Zanella: > >>> +/* The remainder of this file is used to keep specific symbol versions >>> + occupied, so that ld does not generate weak symbol version >>> + definitions. */ >>> + >> >> I think it should built only for SHARED. > > That's handled externally in dlfcn/Makefile (libdl-shared-only-routines). > Ok, so you can ignore this suggestion then.