From: Paul E Murphy <murphyp@linux.ibm.com>
To: "Gabriel F. T. Gomes" <gabriel@inconstante.net.br>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v3 11/11] RFC: powerpc64le: Enable support for IEEE long double
Date: Fri, 13 Dec 2019 23:46:00 -0000 [thread overview]
Message-ID: <3c697aa9-4aec-0d9b-b120-83e1b34e551e@linux.ibm.com> (raw)
In-Reply-To: <20191213194136.14608794@tereshkova>
On 12/13/19 4:41 PM, Gabriel F. T. Gomes wrote:
> On Mon, 09 Dec 2019, Paul E Murphy wrote:
>> Ignoring the individual files for a moment, is it appropriate to split
>> this into one or more patches to introduce the
>> __LONG_DOUBLE_USE_FLOAT128 usage into the various user headers?
>
> Since __LONG_DOUBLE_USES_FLOAT128 is only defined to 1 in
> ldbl-ibm128-compat's bits/long-double.h, I suppose this could work. It's
> always defined to 0 by all other bits/long-double.h headers (as suggested
> by Florian [1]), including what's currently installed for powerpc64le.
>
> Let me check if I got your suggestion right. Are you suggesting that all
> the changes to installed headers in this patch be split into a separate
> patch that can be integrated to master? Then, this patch (the last one)
> would only touch the Implies, .abilist, and ldbl-128ibm-compat-abi.h
> files...
>
> I.e.:
>
>>> sysdeps/powerpc/powerpc64/le/Implies-before | 1 +
>>> .../powerpc64/le/ldbl-128ibm-compat-abi.h | 8 ++
>>> .../linux/powerpc/powerpc64/le/libc.abilist | 93 ++++++++++++++++
>>> .../linux/powerpc/powerpc64/le/libm.abilist | 104 ++++++++++++++++++
>
> ^ these?
Exactly. They can remain inert until the remaining support arrives and
is enabled, while getting the benefit of any ancillary refactoring
occuring while the remaining libm work is finalized. Though, that is my
opinion and may not represent a consensus.
prev parent reply other threads:[~2019-12-13 23:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 17:05 [PATCH v3 00/11] Add IEEE long double <-> string functions for powerpc64le Gabriel F. T. Gomes
2019-12-03 17:05 ` [PATCH v3 01/11] ldbl-128ibm-compat: Fix selection of GNU and ISO C99 scanf Gabriel F. T. Gomes
2019-12-09 16:46 ` Paul E Murphy
2019-12-09 16:50 ` Zack Weinberg
2019-12-09 17:09 ` Paul E Murphy
2019-12-09 18:16 ` Gabriel F. T. Gomes
2019-12-09 20:31 ` Paul E Murphy
2019-12-12 13:42 ` Gabriel F. T. Gomes
2019-12-03 17:06 ` [PATCH v3 03/11] Refactor *cvt functions implementation (1-4/5) Gabriel F. T. Gomes
2019-12-09 21:25 ` Paul E Murphy
2019-12-13 20:19 ` Gabriel F. T. Gomes
2019-12-03 17:06 ` [PATCH v3 06/11] Do not redirect calls to __GI_* symbols, when redirecting to *ieee128 Gabriel F. T. Gomes
2019-12-03 17:06 ` [PATCH v3 02/11] ldbl-128ibm-compat: Add ISO C99 versions of scanf functions Gabriel F. T. Gomes
2019-12-09 18:09 ` Paul E Murphy
2019-12-13 21:13 ` Gabriel F. T. Gomes
2019-12-03 17:06 ` [PATCH v3 10/11] powerpc64le: Require a compiler with -mno-gnu-attribute Gabriel F. T. Gomes
2019-12-03 17:06 ` [PATCH v3 07/11] ldbl-128ibm-compat: Compiler flags for stdio functions Gabriel F. T. Gomes
2019-12-03 17:06 ` [PATCH v3 08/11] Avoid compat symbols for totalorder in powerpc64le IEEE long double Gabriel F. T. Gomes
2019-12-03 17:06 ` [PATCH v3 05/11] ldbl-128ibm-compat: Add *cvt functions Gabriel F. T. Gomes
2019-12-09 23:13 ` Paul E Murphy
2019-12-13 20:03 ` Gabriel F. T. Gomes
2019-12-03 17:06 ` [PATCH v3 04/11] Refactor *cvt functions implementation (5/5) Gabriel F. T. Gomes
2019-12-03 17:06 ` [PATCH v3 09/11] ldbl-128ibm-compat: Do not mix -mabi=*longdouble and -mlong-double-128 Gabriel F. T. Gomes
2019-12-03 17:07 ` [PATCH v3 11/11] RFC: powerpc64le: Enable support for IEEE long double Gabriel F. T. Gomes
2019-12-09 23:47 ` Paul E Murphy
2019-12-13 22:41 ` Gabriel F. T. Gomes
2019-12-13 23:46 ` Paul E Murphy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c697aa9-4aec-0d9b-b120-83e1b34e551e@linux.ibm.com \
--to=murphyp@linux.ibm.com \
--cc=gabriel@inconstante.net.br \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).