From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: "Carlos O'Donell" <carlos@redhat.com>,
libc-alpha@sourceware.org, "Vineet Gupta" <vineetg@rivosinc.com>,
"Ludovic Courtès" <ludo@gnu.org>
Subject: Re: [PATCH 5/6] configure: Allow user override LD, AR, OBJCOPY, and GPROF
Date: Wed, 7 Dec 2022 17:04:04 -0300 [thread overview]
Message-ID: <3c8b38c7-979d-73fc-219c-f0995a0342b2@linaro.org> (raw)
In-Reply-To: <3f7184fd-02e3-42f7-46de-b9f7e5fbbace@redhat.com>
On 05/12/22 12:56, Carlos O'Donell wrote:
> On 12/2/22 14:00, Adhemerval Zanella via Libc-alpha wrote:
>> The only way to override LD, AR, OBJCOPY, and GPROF is through
>> --with-binutils (setting the environments variables on configure is
>> overridden by LIBC_PROG_BINUTILS).
>
> If this is true then doesn't build-many-glibcs.py need --with-binutils?
>
> We set LD, AR, OBJCOPY in bmg (not GPROF though).
>
> I'd think we'd either set them or let the defaults be used (remove their setting).
build-many-glibcs.py (bmg) glibcs option generates a working config, but not
fully concise:
$ grep -e "AR =" -e "AS =" -e "LD =" -e "NM =" -e "OBJCOPY =" -e "OBJDUMP =" -e "RANLIB =" -e "READELF =" -e "STRIP =" config.make
AR = [...]/x86_64-linux-gnu/bin/../lib/gcc/x86_64-glibc-linux-gnu/12.1.1/../../../../x86_64-glibc-linux-gnu/bin/ar
NM = x86_64-glibc-linux-gnu-nm
AS = $(CC) -c
OBJDUMP = [...]/x86_64-linux-gnu/bin/../lib/gcc/x86_64-glibc-linux-gnu/12.1.1/../../../../x86_64-glibc-linux-gnu/bin/objdump
OBJCOPY = [...]/x86_64-linux-gnu/bin/../lib/gcc/x86_64-glibc-linux-gnu/12.1.1/../../../../x86_64-glibc-linux-gnu/bin/objcopy
READELF = x86_64-glibc-linux-gnu-readelf
So some tools are set from "$CC --print-prog-name", while others are set from
the environment variable. It works for bmg because it sets the PATH to the
bmg own toolchain.
So I agree that with this change there is no need to setup the bmg env. vars
anymore. I have sent an updated version.
next prev parent reply other threads:[~2022-12-07 20:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 19:00 [PATCH 0/6] Refactor binutils configure usage Adhemerval Zanella
2022-12-02 19:00 ` [PATCH 1/6] configure: Move locale tools early Adhemerval Zanella
2022-12-05 15:56 ` Carlos O'Donell
2022-12-02 19:00 ` [PATCH 2/6] configure: Remove check if as is GNU Adhemerval Zanella
2022-12-05 15:56 ` Carlos O'Donell
2022-12-02 19:00 ` [PATCH 3/6] configure: Remove check if ld " Adhemerval Zanella
2022-12-05 15:56 ` Carlos O'Donell
2022-12-02 19:00 ` [PATCH 4/6] configure: Remove AS check Adhemerval Zanella
2022-12-05 15:56 ` Carlos O'Donell
2022-12-06 13:45 ` Andreas Schwab
2022-12-06 15:59 ` Adhemerval Zanella Netto
2022-12-02 19:00 ` [PATCH 5/6] configure: Allow user override LD, AR, OBJCOPY, and GPROF Adhemerval Zanella
2022-12-05 15:56 ` Carlos O'Donell
2022-12-07 20:04 ` Adhemerval Zanella Netto [this message]
2022-12-02 19:00 ` [PATCH 6/6] configure: Move nm, objdump, and readelf to LIBC_PROG_BINUTILS Adhemerval Zanella
2022-12-02 23:10 ` Rajalakshmi Srinivasaraghavan
2022-12-06 13:39 ` Adhemerval Zanella Netto
2022-12-05 15:57 ` Carlos O'Donell
2022-12-20 22:01 ` [PATCH 0/6] Refactor binutils configure usage Vineet Gupta
2022-12-22 12:54 ` Adhemerval Zanella Netto
2023-01-05 21:39 ` Vineet Gupta
2023-01-05 21:54 ` Adhemerval Zanella Netto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c8b38c7-979d-73fc-219c-f0995a0342b2@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=carlos@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=ludo@gnu.org \
--cc=vineetg@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).